From owner-svn-ports-head@freebsd.org Sun Dec 31 16:54:22 2017 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A9F3EE8685B; Sun, 31 Dec 2017 16:54:22 +0000 (UTC) (envelope-from swills@FreeBSD.org) Received: from mouf.net (mouf.net [IPv6:2607:fc50:0:4400:216:3eff:fe69:33b3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mouf.net", Issuer "mouf.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 650477A07C; Sun, 31 Dec 2017 16:54:22 +0000 (UTC) (envelope-from swills@FreeBSD.org) Received: from lrrr.mouf.net (cpe-2606-A000-4102-2500-6245-CBFF-FE5F-6C74.dyn6.twc.com [IPv6:2606:a000:4102:2500:6245:cbff:fe5f:6c74]) (authenticated bits=0) by mouf.net (8.14.9/8.14.9) with ESMTP id vBVGs5D1010437 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sun, 31 Dec 2017 16:54:11 GMT (envelope-from swills@FreeBSD.org) Subject: Re: svn commit: r457671 - head/textproc/rubygem-loofah To: Sunpoet Po-Chuan Hsieh Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, idefix@fechner.net, Torsten Zuehlsdorff References: <201712310635.vBV6ZKUq075623@repo.freebsd.org> From: Steve Wills Message-ID: Date: Sun, 31 Dec 2017 11:54:00 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mouf.net [IPv6:2607:fc50:0:4400:216:3eff:fe69:33b3]); Sun, 31 Dec 2017 16:54:12 +0000 (UTC) X-Spam-Status: No, score=0.0 required=4.5 tests=none autolearn=unavailable autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mouf.net X-Virus-Scanned: clamav-milter 0.99.2 at mouf.net X-Virus-Status: Clean X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Dec 2017 16:54:22 -0000 Hi, On 12/31/2017 09:01, Sunpoet Po-Chuan Hsieh wrote: > On Sun, Dec 31, 2017 at 2:35 PM, Steve Wills > wrote: > > Author: swills > Date: Sun Dec 31 06:35:19 2017 > New Revision: 457671 > URL: https://svnweb.freebsd.org/changeset/ports/457671 > > > Log: >   textproc/rubygem-loofah: update to 2.1.1 > > > Hi Steve, > > www/gitlab is the only consumer of rubygem-loofah and rubygem-omniauth-saml. > Regarding r457670 and r457671, you may need to patch gitlab because it > requires: > > from Gemfile: > gem 'omniauth-saml', '~> 1.7.0' > gem 'loofah', '~> 2.0.3' > > That's why I did not update them. We should create ports for the versions it needs. We can have those maintained by the GitLab maintainer if that helps avoid the issue, and/or leave a comment in them about why they are there, which will help with removing them if/when they aren't needed any more because GitLab updates to the newer version. First, we should test if GitLab can successfully use the new version and it's just an overly pessimistic version constraint or really needs the old one. I'll leave that to the GitLab port maintainer. I'm happy to help create the needed ports once we confirm we need them. Thanks, Steve