From owner-freebsd-current@FreeBSD.ORG Thu Dec 2 14:03:42 2010 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2FBBB106566B for ; Thu, 2 Dec 2010 14:03:42 +0000 (UTC) (envelope-from imb@protected-networks.net) Received: from sarah.protected-networks.net (sarah.protected-networks.net [IPv6:2001:470:1f07:4e1::1]) by mx1.freebsd.org (Postfix) with ESMTP id DBC518FC0C for ; Thu, 2 Dec 2010 14:03:41 +0000 (UTC) Received: from toshi.auburn.protected-networks.net (toshi.auburn.protected-networks.net [202.12.127.84]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "StartCom Free Certificate Member", Issuer "StartCom Class 1 Primary Intermediate Client CA" (verified OK)) (Authenticated sender: imb@protected-networks.net) by sarah.protected-networks.net (Postfix) with ESMTPSA id 8CB0D61CE; Thu, 2 Dec 2010 09:03:40 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=protected-networks.net; s=200705; t=1291298620; bh=ZZFf4INk/CVP/nPdvBVHOLhRmyx8lGwjaBYgFz1H8wQ=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type; b=VMrveBdoi/heqFQLX6BIFdxRkL8FdqgKnh8o+JxbLm/YqKv1pjvYOCM8C2lPNZxGC Z/JxW00WXcvJSnkjjRLEQykOyxXcBDzOjwjSsl4sBLfMt3lsNYRyJbWiCzJT2zm DomainKey-Signature: a=rsa-sha1; s=200509; d=protected-networks.net; c=nofws; q=dns; h=message-id:date:from:user-agent:mime-version:to:cc:subject: references:in-reply-to:x-enigmail-version:openpgp:content-type; b=PraI6C8lPNnC2he9pzjRZscL0dmOcEUz0ECeBydTARQ4/xbBmoT9HSi6Ko05ndzqi s5oD1bkc8gd7sq4LgCZ8veuv43O9lh+h/L75xUVybRWjHvs1bW1kS7xcEkwlO3t Message-ID: <4CF7A736.9090102@protected-networks.net> Date: Thu, 02 Dec 2010 09:03:34 -0500 From: Michael Butler User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.2.12) Gecko/20101028 Thunderbird/3.1.6 MIME-Version: 1.0 To: Kirk McKusick References: <201012020030.oB20Ubno068176@chez.mckusick.com> In-Reply-To: <201012020030.oB20Ubno068176@chez.mckusick.com> X-Enigmail-Version: 1.1.2 OpenPGP: id=0442D492 Content-Type: multipart/mixed; boundary="------------010008030904080908020305" Cc: Kostik Belousov , current@freebsd.org Subject: Re: How a full fsck screwed up my SU+J filesystem X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Dec 2010 14:03:42 -0000 This is a multi-part message in MIME format. --------------010008030904080908020305 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On 12/01/10 19:30, Kirk McKusick wrote: [ .. snip .. ] > > Thanks all: Garrett for the report, Peter for the way to reproduce > the problem, and Kostik for a fix. I have copied Jeff so that he can > confirm that Kostik's fix is the appropriate thing to do. And I will > take a look at fsck to see if I can make it a bit more paranoid about > removing .sujournal. > > Kirk McKusick There's another case that SU+J fails and the patch has not yet been committed .. specifically, when configure tries to do a directory rename test .. as below .. I am uncertain but it seems that 'dump -L' exhibits a similar behaviour .. completely hung on me at 1am this morning :-( imb -------- Original Message -------- Subject: Re: softupdate with journal panic Date: Tue, 24 Aug 2010 00:12:57 +0300 From: Kostik Belousov To: Peter Holm CC: Michael Butler , Jeff Roberson , current@freebsd.org On Sun, Aug 22, 2010 at 03:21:04PM +0200, Peter Holm wrote: > On Sat, Aug 21, 2010 at 01:49:45PM -0400, Michael Butler wrote: > > While updating sysutils/coreutils port on -current as of this morning > > (SVN r211550), I noted a panic during the directory rename config test. > > > > Your problem seems identical to this report: > > http://docs.freebsd.org/cgi/mid.cgi?AANLkTinPjiOV21kDLZYV5WScrhLMN7DY8E8jVHWPU5mC > I believe that dotdotremref in this case is legitimately NULL. With this assumption, the following patch would help. --------------010008030904080908020305 Content-Type: text/x-diff; name="ffs_softdep-dir.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="ffs_softdep-dir.patch" *** src/sys/ufs/ffs/ffs_softdep.c~ Fri Aug 20 18:10:34 2010 --- src/sys/ufs/ffs/ffs_softdep.c Mon Aug 23 22:14:48 2010 *************** *** 6770,6776 **** mkdir->md_jaddref = NULL; if (mkdir->md_state & MKDIR_PARENT) { if (cancel_jaddref(jaddref, NULL, ! &dirrem->dm_jwork) == 0) { free_jremref(dotdotremref); dotdotremref = NULL; } --- 6770,6777 ---- mkdir->md_jaddref = NULL; if (mkdir->md_state & MKDIR_PARENT) { if (cancel_jaddref(jaddref, NULL, ! &dirrem->dm_jwork) == 0 && ! dotdotremref != NULL) { free_jremref(dotdotremref); dotdotremref = NULL; } --------------010008030904080908020305--