From owner-freebsd-current Sun Feb 16 22:51: 2 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 179A637B401; Sun, 16 Feb 2003 22:51:01 -0800 (PST) Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 20FBA43F93; Sun, 16 Feb 2003 22:51:00 -0800 (PST) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.6/8.12.3) with ESMTP id h1H6os3Y027326; Sun, 16 Feb 2003 23:50:59 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Sun, 16 Feb 2003 23:50:14 -0700 (MST) Message-Id: <20030216.235014.111547234.imp@bsdimp.com> To: nyan@jp.FreeBSD.org Cc: sos@FreeBSD.ORG, current@FreeBSD.ORG, mdodd@FreeBSD.ORG Subject: Re: The cbus driver for pc98 From: "M. Warner Losh" In-Reply-To: <20030209.224741.71137260.nyan@jp.FreeBSD.org> References: <20030209.224741.71137260.nyan@jp.FreeBSD.org> X-Mailer: Mew version 2.1 on Emacs 21.2 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message: <20030209.224741.71137260.nyan@jp.FreeBSD.org> Takahashi Yoshihiro writes: : I have made the cbus driver for pc98 based on i386 isa driver. This : completely removes that PC98 depends on isa driver and also corrects : directory layouts (pc98/i386 -> pc98/pc98 and pc98/pc98 -> pc98/cbus). : : The full patch can get from : http://home.jp.FreeBSD.org/~nyan/patches/cbus.diff.gz : : Soeren, please review the ata part. : http://home.jp.FreeBSD.org/~nyan/patches/cbus-ata.diff.gz : : Warner, please review the oldcard part. : http://home.jp.FreeBSD.org/~nyan/patches/cbus-pccard.diff.gz : : : If it has no problem, I'll commit after required repository copy. Please excuse my tardiness in replying to this review request. I've just finished a large release at work that was consuming much of my time. I do not like this. It seems to take too many files and just do a simple s/isa/cbus/g on them. However, I'm not sure that we want to do that with so many files when the majority of them are very close to being able to just add a second module line. I think it would be better to implement cbus as an 'isa bus subclass'. cbus is an isa-like bus in many respects from a programming point of view. Copying everything is not the right way to approach this problem, imho. It would be better if the cbus bus implemented the isa routines and accepted that 'isa' is a bit if a misnomer. Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message