From owner-freebsd-hackers@FreeBSD.ORG Fri Apr 11 18:10:06 2014 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C9BB2D5B for ; Fri, 11 Apr 2014 18:10:06 +0000 (UTC) Received: from mail-qc0-x233.google.com (mail-qc0-x233.google.com [IPv6:2607:f8b0:400d:c01::233]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8F99D1A86 for ; Fri, 11 Apr 2014 18:10:06 +0000 (UTC) Received: by mail-qc0-f179.google.com with SMTP id m20so6277750qcx.24 for ; Fri, 11 Apr 2014 11:10:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:message-id:subject:from:to:content-type; bh=OjKChS2x2uINttZd/R13nsoGlhUHAtMeM/L7lXAldAo=; b=xYHe6trUS1kdYaZJikUOtStSkRvXFe5vTW5zgKkWrIH6cxlKkIKSzS8Du4Mqq3QxYi MCCEk3X4YjtzeYmOZCH2vBbrraU9phbstmSJhnMDYG8tCsIHRkR7Nx5LUPc8+Xvs2qjz sPVqNY311L2OraHcsDwy0rbLQES1rarbzyIdWiLYo380/I0hLm/UsG2/o4Rnw+aB2LUc tE6wGYeXyzpOj+7F90ZGHkD0K5nG+SJe03pCl3t+PHVCaD5QidIpmRJaABEU+x5b92f4 U+hg62Ok16zYvvf2du/eLK/0yshcvzv3u5fEKCFwLDK7Ms7bhGPGxlO6rq+1WP0HOWDF BxqA== MIME-Version: 1.0 X-Received: by 10.224.65.194 with SMTP id k2mr844854qai.59.1397239805790; Fri, 11 Apr 2014 11:10:05 -0700 (PDT) Sender: carpeddiem@gmail.com Received: by 10.140.88.105 with HTTP; Fri, 11 Apr 2014 11:10:05 -0700 (PDT) Date: Fri, 11 Apr 2014 14:10:05 -0400 X-Google-Sender-Auth: LISMNvc9ogWGt9Xoxu38RR5RqAE Message-ID: Subject: kerberos installworld woes, continued From: Ed Maste To: freebsd-hackers@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Apr 2014 18:10:06 -0000 I recently ran into a reproducible kerberos-related installworld failure in one of my trees. The install fails at: cmp -s krb5_asn1.hx krb5_asn1.h 2> /dev/null || cp krb5_asn1.hx krb5_asn1.h cp: not found Ian Lepore mentioned encountering this in 2012 on freebsd-embedded, and think there have been other reports elsewhere. My case was caused by having a newer krb5_asn1.hx file in the source tree, but with the same content as the krb5_asn1.h copy. This can happen fairly easily with git, when switching between and rebasing various branches. During the buildworld the cmp returns true, so the .h file isn't copied over. Then at installworld the cmp test fails as cmp is not in the temporary path. The cp is invoked, which fails as it is also not in the path. If r262209 fixes the underlying concurrency issue we should be able to drop the cmp completely -- any concerns with this change: diff --git a/kerberos5/lib/libasn1/ Makefile b/kerberos5/lib/libasn1/Makefile index b0f969a..dc1de5c 100644 --- a/kerberos5/lib/libasn1/Makefile +++ b/kerberos5/lib/libasn1/Makefile @@ -112,10 +112,10 @@ ${GEN_KX509}: kx509.asn1 .SUFFIXES: .h .c .x .hx .x.c: - cmp -s ${.IMPSRC} ${.TARGET} 2> /dev/null || cp ${.IMPSRC} ${.TARGET} + cp ${.IMPSRC} ${.TARGET} .hx.h: - cmp -s ${.IMPSRC} ${.TARGET} 2> /dev/null || cp ${.IMPSRC} ${.TARGET} + cp ${.IMPSRC} ${.TARGET} .include