From owner-svn-src-all@FreeBSD.ORG Mon Jan 4 14:45:31 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DCD5310656B9; Mon, 4 Jan 2010 14:45:31 +0000 (UTC) (envelope-from gallatin@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id CA2D08FC0A; Mon, 4 Jan 2010 14:45:31 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o04EjVqj088392; Mon, 4 Jan 2010 14:45:31 GMT (envelope-from gallatin@svn.freebsd.org) Received: (from gallatin@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o04EjVkT088390; Mon, 4 Jan 2010 14:45:31 GMT (envelope-from gallatin@svn.freebsd.org) Message-Id: <201001041445.o04EjVkT088390@svn.freebsd.org> From: Andrew Gallatin Date: Mon, 4 Jan 2010 14:45:31 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-7@freebsd.org X-SVN-Group: stable-7 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r201500 - stable/7/sys/dev/mxge X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Jan 2010 14:45:32 -0000 Author: gallatin Date: Mon Jan 4 14:45:31 2010 New Revision: 201500 URL: http://svn.freebsd.org/changeset/base/201500 Log: MFC 200845: Don't take the driver mutex in mxge_tick(), as it is run with the mutex held. Modified: stable/7/sys/dev/mxge/if_mxge.c Directory Properties: stable/7/sys/ (props changed) stable/7/sys/cddl/contrib/opensolaris/ (props changed) stable/7/sys/contrib/dev/acpica/ (props changed) stable/7/sys/contrib/pf/ (props changed) Modified: stable/7/sys/dev/mxge/if_mxge.c ============================================================================== --- stable/7/sys/dev/mxge/if_mxge.c Mon Jan 4 14:43:23 2010 (r201499) +++ stable/7/sys/dev/mxge/if_mxge.c Mon Jan 4 14:45:31 2010 (r201500) @@ -3638,9 +3638,7 @@ mxge_tick(void *arg) uint16_t cmd; ticks = mxge_ticks; - mtx_lock(&sc->driver_mtx); running = sc->ifp->if_drv_flags & IFF_DRV_RUNNING; - mtx_unlock(&sc->driver_mtx); if (running) { /* aggregate stats from different slices */ pkts = mxge_update_stats(sc);