From owner-cvs-src@FreeBSD.ORG Wed Jan 11 13:47:14 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 046AA16A420; Wed, 11 Jan 2006 13:47:14 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8163C43D48; Wed, 11 Jan 2006 13:47:12 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.5b3) with ESMTP id 5792760 for multiple; Wed, 11 Jan 2006 08:45:36 -0500 Received: from zion.baldwin.cx (zion.baldwin.cx [192.168.0.7]) (authenticated bits=0) by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k0BDlAAq071287; Wed, 11 Jan 2006 08:47:10 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Scott Long Date: Wed, 11 Jan 2006 08:47:06 -0500 User-Agent: KMail/1.8.3 References: <200601110037.k0B0bDv4009424@repoman.freebsd.org> In-Reply-To: <200601110037.k0B0bDv4009424@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200601110847.08614.jhb@freebsd.org> X-Virus-Scanned: ClamAV 0.87.1/1238/Wed Jan 11 05:19:06 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.4 required=4.2 tests=ALL_TRUSTED autolearn=failed version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx X-Server: High Performance Mail Server - http://surgemail.com r=1653887525 Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern subr_taskqueue.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2006 13:47:14 -0000 On Tuesday 10 January 2006 07:37 pm, Scott Long wrote: > scottl 2006-01-11 00:37:13 UTC > > FreeBSD src repository > > Modified files: > sys/kern subr_taskqueue.c > Log: > The interlock in taskqueue_terminate() is completely wrong for taskqueu= es > that use spinlocks. Remove it for now. Eh? It's waiting for the wakeup that comes from kthread_exit() after the=20 thread has exited which is locked via the proc lock. Sleeping on the=20 taskqueue itself doesn't buy you anything. (In fact, it might sleep=20 forever.) The simplest solution might be to acquire the proc lock a lot=20 earlier before the taskqueue lock in this function so that you don't have t= o=20 acquire it while holding the taskqueue lock since that is what gives you=20 problems. =2D-=20 John Baldwin =A0<>< =A0http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" =A0=3D =A0http://www.FreeBSD.org