From owner-p4-projects@FreeBSD.ORG  Tue Jun 24 16:20:17 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id D4ED8106567A; Tue, 24 Jun 2008 16:20:16 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7D4971065677
	for <perforce@freebsd.org>; Tue, 24 Jun 2008 16:20:16 +0000 (UTC)
	(envelope-from gabor@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 759C08FC1F
	for <perforce@freebsd.org>; Tue, 24 Jun 2008 16:20:16 +0000 (UTC)
	(envelope-from gabor@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m5OGKGwr096463
	for <perforce@freebsd.org>; Tue, 24 Jun 2008 16:20:16 GMT
	(envelope-from gabor@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m5OGKGpj096461
	for perforce@freebsd.org; Tue, 24 Jun 2008 16:20:16 GMT
	(envelope-from gabor@freebsd.org)
Date: Tue, 24 Jun 2008 16:20:16 GMT
Message-Id: <200806241620.m5OGKGpj096461@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	gabor@freebsd.org using -f
From: Gabor Kovesdan <gabor@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 144027 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Jun 2008 16:20:17 -0000

http://perforce.freebsd.org/chv.cgi?CH=144027

Change 144027 by gabor@gabor_server on 2008/06/24 16:20:03

	- Drop some unnecessary function parameters

Affected files ...

.. //depot/projects/soc2008/gabor_textproc/grep/file.c#9 edit
.. //depot/projects/soc2008/gabor_textproc/grep/grep.h#24 edit
.. //depot/projects/soc2008/gabor_textproc/grep/util.c#38 edit

Differences ...

==== //depot/projects/soc2008/gabor_textproc/grep/file.c#9 (text+ko) ====

@@ -60,7 +60,7 @@
 };
 
 struct file *
-grep_stdin_open(char *mode)
+grep_stdin_open(void)
 {
 	struct file	*f;
 
@@ -70,7 +70,7 @@
 
 	f->type = FILE_STDIO;
 	f->noseek = isatty(FILE_STDIO);
-	if ((f->f = fdopen(FILE_STDIO, mode)) != NULL)
+	if ((f->f = fdopen(FILE_STDIO, "r")) != NULL)
 		return (f);
 
 	free(f);
@@ -78,7 +78,7 @@
 }
 
 struct file *
-grep_open(char *path, char *mode)
+grep_open(char *path)
 {
 	struct file	*f;
 
@@ -90,12 +90,12 @@
 /* XXX: pre-extract gzip and bzip2 files */
 
 	/* try mmap first; if it fails, try stdio */
-	if ((f->mmf = mmopen(fname, mode)) != NULL) {
+	if ((f->mmf = mmopen(fname, "r")) != NULL) {
 		f->type = FILE_MMAP;
 		return (f);
 	}
 	f->type = FILE_STDIO;
-	if ((f->f = fopen(path, mode)) != NULL)
+	if ((f->f = fopen(path, "r")) != NULL)
 		return (f);
 
 	free(f);

==== //depot/projects/soc2008/gabor_textproc/grep/grep.h#24 (text+ko) ====

@@ -129,8 +129,8 @@
 /* file.c */
 struct file;
 
-struct file	*grep_stdin_open(char *mode);
-struct file	*grep_open(char *path, char *mode);
+struct file	*grep_stdin_open(void);
+struct file	*grep_open(char *path);
 int		 grep_bin_file(struct file *f);
 char		*grep_fgetln(struct file *f, size_t *l);
 void		 grep_close(struct file *f);

==== //depot/projects/soc2008/gabor_textproc/grep/util.c#38 (text+ko) ====

@@ -135,9 +135,9 @@
 			fn = label;
 		else
 			fn = getstr(1);
-		f = grep_stdin_open("r");
+		f = grep_stdin_open();
 	} else {
-		f = grep_open(fn, "r");
+		f = grep_open(fn);
 	}
 	if (f == NULL) {
 		if (!sflag)