From owner-svn-src-all@freebsd.org Fri Dec 14 02:39:11 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 46778130B663; Fri, 14 Dec 2018 02:39:11 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B868486464; Fri, 14 Dec 2018 02:39:10 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pg1-x531.google.com with SMTP id w7so1957018pgp.13; Thu, 13 Dec 2018 18:39:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:reply-to:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jSmbOrSr3PJSjoNC88DfiDE6RYuzC4fzA1Ue3BJ6a0U=; b=TpR9PSsbAxCipu1uGw1g70zg9k+Q5iZmdgEHF120XlL6QUB3MTKeK/yW42wbx/ma1r YvOQXkaXxRCr28JsxoSXR5J+DA2d04R23kLeZ0zLZjkZqD67ukpnSOilAhT18AQbR8H9 kWxrxrgNA6EwfwEfpQ6KjdnFOsCA1za1sHmV3pc91/0GIsdjsjFbkCkZlplukedLnjl0 m0zm5j70y4zGHaesx5CetZa8dB6etONrZPwO2agywblrMlU6KEvh6+a84RKi3oUaf+5C PL4qtSwaK3OPJkFLTwerA3Ohko/PTUx3IwKpPMnBL03cvaubLb6Hi+aDR+49+4UOthO+ 4v/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:reply-to:subject:to:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=jSmbOrSr3PJSjoNC88DfiDE6RYuzC4fzA1Ue3BJ6a0U=; b=mSI/KeoM51bDm42jiViyiYoQLMn5pYlkD8MQIalvFV3AM/QLuRUL4ugrAuJs3M5iXc DtbvvNjZNRM0JZHFxlY3PMSDuCoRW0hz1gvJLS2jWgtEEnMLZ/T9KNVHH2LMu3y0r0UD mWinpfGLEXQoWCkrBoS78TZoqvCfXst4B1A1jcp0Xz6TAcdrvEuCYDm5cQjqQAedscba G6FoIdQaaizWV9O3YaFQiN5+KZB6JfzeRhjiPJ4Xthqayzfvy+GfN970/famosZsHNOg 8bUYiHv98A6eGVnqonktjxViV3DYRZELfjMmVXeq97dijn+J1zTvi47RksLurGZSr0p8 iCTg== X-Gm-Message-State: AA+aEWbP4lHfQ3AyawXBluMSqGIn1PaBDyKhKXEcfFX4ojPxDV1LKF0n BJE0KBv6smhg5dYM5Z7qQ9u4NFDj X-Google-Smtp-Source: AFSGD/V9pGuA/ZkRL9qBPpEiMSwLGAPQpcuSTci0jSvSZjLcuHRkDY44ptv3jmxp7EC7AzY9382/Jg== X-Received: by 2002:a63:f515:: with SMTP id w21mr1184769pgh.220.1544755149525; Thu, 13 Dec 2018 18:39:09 -0800 (PST) Received: from ?IPv6:2403:5800:7100:5d01:41fd:8f07:9f95:2994? (2403-5800-7100-5d01-41fd-8f07-9f95-2994.ip6.aussiebb.net. [2403:5800:7100:5d01:41fd:8f07:9f95:2994]) by smtp.gmail.com with ESMTPSA id m19sm9863432pgn.35.2018.12.13.18.39.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Dec 2018 18:39:09 -0800 (PST) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: svn commit: r342057 - head/crypto/openssl/crypto/engine To: Jung-uk Kim , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201812140106.wBE16Zgr058499@repo.freebsd.org> From: Kubilay Kocak Message-ID: <216fb35b-28d1-faaa-d115-1f4a601212f0@FreeBSD.org> Date: Fri, 14 Dec 2018 13:39:03 +1100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:64.0) Gecko/20100101 Thunderbird/64.0 MIME-Version: 1.0 In-Reply-To: <201812140106.wBE16Zgr058499@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B868486464 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-5.89 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.996,0]; NEURAL_HAM_SHORT(-0.90)[-0.897,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Dec 2018 02:39:11 -0000 On 14/12/2018 12:06 pm, Jung-uk Kim wrote: > Author: jkim > Date: Fri Dec 14 01:06:34 2018 > New Revision: 342057 > URL: https://svnweb.freebsd.org/changeset/base/342057 > > Log: > Do not complain when /dev/crypto does not exist. > > Now the new devcrypto engine is enabled since r342009, many users started > seeing "Could not open /dev/crypto: No such file or directory". Disable > the annoying error message as it is not very useful anyway. > > Note the patch was submitted upstream. > > https://github.com/openssl/openssl/pull/7896 > > Modified: > head/crypto/openssl/crypto/engine/eng_devcrypto.c > > Modified: head/crypto/openssl/crypto/engine/eng_devcrypto.c > ============================================================================== > --- head/crypto/openssl/crypto/engine/eng_devcrypto.c Fri Dec 14 00:40:38 2018 (r342056) > +++ head/crypto/openssl/crypto/engine/eng_devcrypto.c Fri Dec 14 01:06:34 2018 (r342057) > @@ -24,6 +24,8 @@ > > #include "internal/engine.h" > > +/* #define ENGINE_DEVCRYPTO_DEBUG */ > + > #ifdef CRYPTO_ALGORITHM_MIN > # define CHECK_BSD_STYLE_MACROS > #endif > @@ -615,6 +617,9 @@ void engine_load_devcrypto_int() > ENGINE *e = NULL; > > if ((cfd = open("/dev/crypto", O_RDWR, 0)) < 0) { > +#ifndef ENGINE_DEVCRYPTO_DEBUG > + if (errno != ENOENT) > +#endif > fprintf(stderr, "Could not open /dev/crypto: %s\n", strerror(errno)); > return; > } How trivially could devcrypto_debug be modified to be a runtime configuration (say sysctl) setting?