From owner-svn-ports-all@freebsd.org Wed Nov 7 17:31:54 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3F1BB112B139; Wed, 7 Nov 2018 17:31:54 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C2D1471E4E; Wed, 7 Nov 2018 17:31:53 +0000 (UTC) (envelope-from jbeich@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1354) id 94CB312185; Wed, 7 Nov 2018 17:31:53 +0000 (UTC) From: Jan Beich To: Alexey Dokuchaev Cc: Tobias Kortkamp , svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r484222 - in head/mail/libdomainkeys: . files References: <201811052109.wA5L9f22029571@repo.freebsd.org> <20181106134950.GA12772@FreeBSD.org> <1541536096.2238291.1567906016.21263D52@webmail.messagingengine.com> <20181107165059.GA97864@FreeBSD.org> Date: Wed, 07 Nov 2018 18:31:50 +0100 In-Reply-To: <20181107165059.GA97864@FreeBSD.org> (Alexey Dokuchaev's message of "Wed, 7 Nov 2018 16:50:59 +0000") Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: C2D1471E4E X-Spamd-Result: default: False [-106.78 / 200.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; ALLOW_DOMAIN_WHITELIST(-100.00)[freebsd.org]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[FreeBSD.org]; R_SPF_SOFTFAIL(0.00)[~all]; RCPT_COUNT_FIVE(0.00)[5]; IP_SCORE(-3.67)[ip: (-9.59), ipnet: 2610:1c1:1::/48(-4.91), asn: 11403(-3.76), country: US(-0.09)]; MX_GOOD(-0.01)[cached: mx66.freebsd.org]; NEURAL_HAM_SHORT(-1.00)[-0.998,0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Nov 2018 17:31:54 -0000 Alexey Dokuchaev writes: > On Tue, Nov 06, 2018 at 09:28:16PM +0100, Tobias Kortkamp wrote: > >> On Tue, Nov 6, 2018, at 14:49, Alexey Dokuchaev wrote: >> > On Mon, Nov 05, 2018 at 09:09:41PM +0000, Tobias Kortkamp wrote: >> > > New Revision: 484222 >> > > URL: https://svnweb.freebsd.org/changeset/ports/484222 >> > > >> > > Log: >> > > mail/libdomainkeys: Unbreak with OpenSSL 1.1.1 [1] >> > > >> > > ++#if OPENSSL_VERSION_NUMBER < 0x1010000fL >> > >> > I think this should be 0x10100005L instead; ditto below. >> >> Why? > > I recall that API opaqueness changes were first introduced in 1.1.0-pre5 > (hence 0x10100005L), but got lost in their GitHub mirror to provide you > with exact evidence link (git is just atrocious for code archaeology). Did you mean https://github.com/openssl/openssl/commit/7638370ca6cb ? $ git describe --contains 7638370ca6cb OpenSSL_1_1_0-pre1~120 $ git grep 'define.*OPENSSL_VERSION_NUMBER' OpenSSL_1_1_0-pre1 \*.h OpenSSL_1_1_0-pre1:include/openssl/opensslv.h:# define OPENSSL_VERSION_NUMBER 0x10100001L