From owner-freebsd-amd64@FreeBSD.ORG  Fri Mar 16 21:00:22 2012
Return-Path: <owner-freebsd-amd64@FreeBSD.ORG>
Delivered-To: freebsd-amd64@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2CFDC1065670
	for <freebsd-amd64@hub.freebsd.org>;
	Fri, 16 Mar 2012 21:00:22 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 185348FC14
	for <freebsd-amd64@hub.freebsd.org>;
	Fri, 16 Mar 2012 21:00:22 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q2GL0LXO068445
	for <freebsd-amd64@freefall.freebsd.org>; Fri, 16 Mar 2012 21:00:21 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q2GL0Lku068440;
	Fri, 16 Mar 2012 21:00:21 GMT (envelope-from gnats)
Date: Fri, 16 Mar 2012 21:00:21 GMT
Message-Id: <201203162100.q2GL0Lku068440@freefall.freebsd.org>
To: freebsd-amd64@FreeBSD.org
From: Peter Wemm <peter@wemm.org>
Cc: 
Subject: Re: amd64/163710: setjump in userboot.so causes stack corruption
X-BeenThere: freebsd-amd64@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Peter Wemm <peter@wemm.org>
List-Id: Porting FreeBSD to the AMD64 platform <freebsd-amd64.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-amd64>,
	<mailto:freebsd-amd64-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-amd64>
List-Post: <mailto:freebsd-amd64@freebsd.org>
List-Help: <mailto:freebsd-amd64-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-amd64>,
	<mailto:freebsd-amd64-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Mar 2012 21:00:22 -0000

The following reply was made to PR amd64/163710; it has been noted by GNATS.

From: Peter Wemm <peter@wemm.org>
To: Russell Cattelan <cattelan@thebarn.com>
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: amd64/163710: setjump in userboot.so causes stack corruption
Date: Fri, 16 Mar 2012 13:51:18 -0700

 2012/3/16 Russell Cattelan <cattelan@thebarn.com>:
 > -----BEGIN PGP SIGNED MESSAGE-----
 > Hash: SHA1
 >
 > On 3/16/12 11:56 AM, Peter Wemm wrote:
 >> On Thu, Mar 15, 2012 at 2:40 PM, Russell Cattelan
 >> <cattelan@thebarn.com> wrote:
 >>> The following reply was made to PR amd64/163710; it has been
 >>> noted by GNATS.
 >> [..]
 >>> Does the last patch seem acceptable?
 >>>
 >>> Can we close this issue out?
 >>
 >> Sadly not,
 >>
 >> +no-machine: + rm -f =A0 ${.CURDIR}/../../ficl/machine
 >>
 >> .. this is definitely bogus no matter what. This attempts to
 >> modify the source tree which may be read only, and should never
 >> even have a "machine->..." symlink in it to remove in the first
 >> place.
 > The sym link is created by the build of ficl for the loader.
 > See: boot/ficl/Makefile
 > machine:
 > =A0 =A0 =A0 =A0ln -sf ${.CURDIR}/../../i386/include machine
 >
 > Are you suggesting that is incorrect and should be fixed?
 
 No, you're reading it wrong:
 "ln -sf ${.CURDIR}/../../i386/include machine"
 creates ${.OBJDIR}/machine"
 
 Your patch does a "rm -f   ${.CURDIR}/../../ficl/machine" which is in
 the source tree, not the obj tree, so it would never exist.  And if it
 does, then something is wrong with your build environment.
 
 --=20
 Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com; KI6FJV
 "All of this is for nothing if we don't go to the stars" - JMS/B5
 "If Java had true garbage collection, most programs would delete
 themselves upon execution." -- Robert Sewell