From owner-svn-ports-all@FreeBSD.ORG  Sat May 11 11:01:10 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@FreeBSD.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id D3F10E53; Sat, 11 May 2013 11:01:10 +0000 (UTC)
Date: Sat, 11 May 2013 11:01:10 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Lars Engels <lars.engels@0x20.net>
Subject: Re: svn commit: r317834 - head/astro/swe
Message-ID: <20130511110110.GA92017@FreeBSD.org>
References: <201305101828.r4AISZWi094449@svn.freebsd.org>
 <20130511091807.GA67148@FreeBSD.org>
 <20130511095605.GV32935@e-new.0x20.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130511095605.GV32935@e-new.0x20.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: Lars Engels <lme@FreeBSD.org>, svn-ports-head@FreeBSD.org,
 svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 11 May 2013 11:01:10 -0000

On Sat, May 11, 2013 at 11:56:05AM +0200, Lars Engels wrote:
> On Sat, May 11, 2013 at 09:18:07AM +0000, Alexey Dokuchaev wrote:
> > On Fri, May 10, 2013 at 06:28:35PM +0000, Lars Engels wrote:
> > > New Revision: 317834
> > > URL: http://svnweb.freebsd.org/changeset/ports/317834
> > > 
> > > @@ -24,6 +24,10 @@ post-patch:
> > >  		-e 's|CFLAGS =|CFLAGS ?=|' \
> > >  		${WRKSRC}/Makefile
> > >  
> > > +.if ${OSVERSION} >= 100000
> > > +	@${REINPLACE_CMD} -e 's|-O9|-O3|' ${WRKSRC}/Makefile
> > > +.endif
> > 
> > Any reason for this fix being conditional on OSVERSION?
> 
> I assumed that -O9 didn't work with CLANG on current, but I just checked
> this and the port gets automatically build with -O2.
> I'll talk about it with the PR submitter if it's necessary.

It would be awesome if the port could be teached to uphold our CFLAGS
instead of using hardcoded (very bogus) -O9 or whatever.

./danfe