Date: Wed, 6 Oct 1999 10:54:39 -0700 (PDT) From: Matthew Dillon <dillon@apollo.backplane.com> To: Poul-Henning Kamp <phk@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern vfs_subr.c src/sys/miscfs/specfs spec_vnops.c src/sys/sys vnode.h Message-ID: <199910061754.KAA86572@apollo.backplane.com> References: <199910041123.EAA15848@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This commit is completely unacceptable. I have had my patchset
to deal with buffered block devices in the queue for several weeks
now and Poul knows it. Furthermore, this patch simpy revisits
changes made to the block device which were deemed unacceptable a
number of weeks ago and were backed out then.
Poul, please back-out the operational changes to the buffered block
device that you've made here. Your changes completely destroy cache
coherency between read/write and mmap() on a buffered block device.
Additionally, your changes destroy the buffered block device's
reblocking capabilities. I will also note that there is no reviewer
indicated in the commit logs, another point that I had hoped had been
resolved by that huge mess a few weeks ago but which obviously has not
been.
We went through all this several weeks ago. Nothing has changed,
except I've had a patchset for buffered block devices that implement
the correct methodology which has been under test and up for review
and not yet committed, which you just trod over. Please back these
changes out.
-Matt
Matthew Dillon
<dillon@backplane.com>
:
:phk 1999/10/04 04:23:10 PDT
:
: Modified files:
: sys/kern vfs_subr.c
: sys/miscfs/specfs spec_vnops.c
: sys/sys vnode.h
: Log:
: Move the buffered read/write code out of spec_{read|write} and into
: two new functions spec_buf{read|write}.
:
: Add sysctl vfs.bdev_buffered which defaults to 1 == true. This
: sysctl can be used to experimentally turn buffered behaviour for
: bdevs off. I should not be changed while any blockdevices are
: open. Remove the misplaced sysctl vfs.enable_userblk_io.
:
: No other changes in behaviour.
:
: Revision Changes Path
: 1.230 +1 -4 src/sys/kern/vfs_subr.c
: 1.116 +211 -182 src/sys/miscfs/specfs/spec_vnops.c
: 1.103 +1 -2 src/sys/sys/vnode.h
:
:
:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199910061754.KAA86572>