From owner-svn-src-head@freebsd.org Tue Jan 3 16:06:55 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CB1C7C9DA6A for ; Tue, 3 Jan 2017 16:06:55 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm23-vm0.bullet.mail.ne1.yahoo.com (nm23-vm0.bullet.mail.ne1.yahoo.com [98.138.91.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 93FF41D81 for ; Tue, 3 Jan 2017 16:06:55 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1483459608; bh=pFGRsLsJszRZPOVsoMPe8O9pwVwHgtA2OXWZa949+oE=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From:Subject; b=nY2CxHe9grdGKZnMde0tJOUMWtFKwr+NGDE5phRtG+CboxU8FOEo7k1baLlQ2PjnJ1nmDwg06By4ECCLBVK8e4e36OQNTPnE2WKRv8VqLLQrK7RLqeCdtslMOXIRIAcle8+5nbAABjl9pBIQHQpec6B9JbzVhEdOhKVb3us0EP/Q+OSNZm0uIIMfyzJxtwbAtNKtT9//2YcfarGNwkDfuRBlLJo4qAOhVWxdXL3TBjg1+XHLymPNJob4KjzEGdtucXDXPSI/l3oX4F7h4DvUHBo0yqXQqLLWenXvJfdcPMZwMlPDs7aA3poOw5wgRX3mdtzKE10O3cf+8gxor6+FpQ== Received: from [98.138.101.128] by nm23.bullet.mail.ne1.yahoo.com with NNFMP; 03 Jan 2017 16:06:48 -0000 Received: from [98.138.84.37] by tm16.bullet.mail.ne1.yahoo.com with NNFMP; 03 Jan 2017 16:06:48 -0000 Received: from [127.0.0.1] by smtp105.mail.ne1.yahoo.com with NNFMP; 03 Jan 2017 16:06:48 -0000 X-Yahoo-Newman-Id: 73210.53980.bm@smtp105.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: G416mMYVM1lzrjc0usXN_q_HQVor9k.RE1rU9U9MQ8MY_JL UAya2AsdfYdQ6TU26bhYlJiVnDdHG0y8mGwXO3XG5mzEn1JaHNb6P8v2OLbf YIQs.6WTFVThe.9UPrWnECdTf13TmkahVfLcAdqGlvIZfNPJDa2cVx3LgukH RNPnNGaB8_MZTdA0Pn0RthdG3lGPFSy8xK8tiWx5K3beG9y_MwY_uQO5Q7pu VSlVdidkgUJrQxkjAbTztfpXY4FnrPtO25qiJyZ_8kLxCfhXJ6DdwjjnGTK6 6hQdsB0.IiLq00tm05gtSLKWidxQJhoea5EA3GXQ5qVbnR3HxWmKbUOu8TJf LGuPJp6CZOcqEiCD4Uc1j7gJD6YqA34OxySZ_P51M9iuK7Fg4ybYbLmGu_EC jBnTUAaRYDq56LGrcI42ad1wufFIEv3zeDeT9ztwDMmGrRkrkpsEEmR61DcH rL7XIFhGsdrlOWhz2R53JsnELjLq6QOxmU1kAOHjNkOhcL7nTVmokBYwdun6 fTpKUCwCAkImTHnempiTbK1BIw1T01EJYl0yn.e4h9WzMfh8- X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: Re: svn commit: r311109 - head/usr.bin/patch To: Ian Lepore , Konstantin Belousov References: <201701021823.v02INWXc028047@repo.freebsd.org> <9c3fc378-ee5e-19ba-c286-1440d4b13615@FreeBSD.org> <20170103102622.GO1923@kib.kiev.ua> <1483458723.16152.107.camel@freebsd.org> Cc: Conrad Meyer , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Pedro Giffuni Message-ID: <385c8ef6-32b9-c703-14d8-2c10f5816b44@FreeBSD.org> Date: Tue, 3 Jan 2017 11:08:28 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1483458723.16152.107.camel@freebsd.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jan 2017 16:06:55 -0000 Hi Ian; On 01/03/17 10:52, Ian Lepore wrote: > On Tue, 2017-01-03 at 12:26 +0200, Konstantin Belousov wrote: >> On Mon, Jan 02, 2017 at 07:41:26PM -0500, Pedro Giffuni wrote: >>> >>> >>> >>> On 01/02/17 17:54, Conrad Meyer wrote: >>>> >>>> I was suggesting using UINT32_MAX/2 on all platforms (which is >>>> safe >>>> everywhere). >>>> >>> Ah OK. INT_MAX is ~ (UINT_MAX / 2) so it's the same to use either. >>> I just think it's clearer to use INT_MAX and the corresponding int >>> type. >>> >>> The other issue is if diff(1) can handle such lines(?). >> Of course it cannot, on ILP32 arches. >> > > I kind of don't understand the premise of the naysayers in this thread. > Some machines cannot do lines that are UINT_MAX long, so in that case > we should not support any lines longer than USHORT_MAX? As if there > aren't *billions* of line length limits to choose from between those > two numbers? > I am considering INT_MAX, which, I think can be reasonably supported by all archs. I looked briefly at GNU diff, and it has a way of specifying the width. It does look like it can handle ints but the default is 130. So yes, it seems supporting something larger than USHORT_MAX may be useful in these "big data" era but it's not urgent. > I'm also trying to picture the real-world need to diff and patch lines > of ascii text longer than 64K, but for every problem out there, there > is someone with a perverse need to solve that problem outside of the > normal lines we all live between. > Pedro. > -- Ian >