From owner-cvs-all Sun Jan 5 20:38:53 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5798637B401; Sun, 5 Jan 2003 20:38:52 -0800 (PST) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9D20E43EA9; Sun, 5 Jan 2003 20:38:51 -0800 (PST) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.6/8.12.2) with ESMTP id h064ckPT025070; Sun, 5 Jan 2003 20:38:46 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.6/8.12.6/Submit) id h064bV9V025060; Sun, 5 Jan 2003 20:37:31 -0800 (PST) Date: Sun, 5 Jan 2003 20:37:31 -0800 From: "David O'Brien" To: Garrett Wollman Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/gen sysconf.c Message-ID: <20030106043730.GA24930@dragon.nuxi.com> Reply-To: obrien@FreeBSD.org Mail-Followup-To: David O'Brien , Garrett Wollman , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200209210214.g8L2E4Wc086892@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200209210214.g8L2E4Wc086892@freefall.freebsd.org> User-Agent: Mutt/1.4i X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, Sep 20, 2002 at 07:14:04PM -0700, Garrett Wollman wrote: > wollman 2002/09/20 19:14:04 PDT > > Modified files: > lib/libc/gen sysconf.c > Log: ... > Implement all of the keys from 1003.1-2001 that we can. Ensure that > the build will break if someone redefines an option constant to zero > without implementing the necessary presence-detection logic here. Would you *PLEASE* keep the manpage in sync when you make changes like this? I added 'LOGIN_NAME_MAX' to syslimits.h as the manpage totally didn't mention it. On a related note, why should 'LOGIN_NAME_MAX' be a run-time value? One of the most common use of it is "char foo[LOGIN_NAME_MAX];". Calling sysconf(3) in this context will not work. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message