From owner-cvs-src@FreeBSD.ORG  Sat Dec 29 13:31:27 2007
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C714116A419;
	Sat, 29 Dec 2007 13:31:27 +0000 (UTC) (envelope-from kib@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id BBA8713C44B;
	Sat, 29 Dec 2007 13:31:27 +0000 (UTC) (envelope-from kib@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id lBTDVRiX028700;
	Sat, 29 Dec 2007 13:31:27 GMT (envelope-from kib@repoman.freebsd.org)
Received: (from kib@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id lBTDVR69028699;
	Sat, 29 Dec 2007 13:31:27 GMT (envelope-from kib)
Message-Id: <200712291331.lBTDVR69028699@repoman.freebsd.org>
From: Konstantin Belousov <kib@FreeBSD.org>
Date: Sat, 29 Dec 2007 13:31:27 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Cc: 
Subject: cvs commit: src/sys/ufs/ffs ffs_balloc.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 29 Dec 2007 13:31:27 -0000

kib         2007-12-29 13:31:27 UTC

  FreeBSD src repository

  Modified files:
    sys/ufs/ffs          ffs_balloc.c 
  Log:
  The ffs_balloc() routines, whan allocating the indirect blocks for
  the inode, do the rollback in case the allocation failed (due to
  insufficient free space or quota limits). But, the code does leaves the
  buffers corresponding to the inoirect blocks on the vnode bufobj list.
  This causes several assertion failures (for instance, "ffs_truncate3"
  in ffs_truncate()) to fail, and could result in the indirect block
  aliasing problem, like writing the context of such blocks to random
  disk location.
  
  Remove the buffers from the bufobj properly.
  
  Reported and tested by: Peter Holm
  Reviewed by:    tegge
  MFC after:      3 weeks
  
  Revision  Changes    Path
  1.52      +42 -2     src/sys/ufs/ffs/ffs_balloc.c