From owner-svn-ports-head@FreeBSD.ORG Mon Feb 25 05:40:38 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 57349697; Mon, 25 Feb 2013 05:40:38 +0000 (UTC) (envelope-from cvs-src@yandex.ru) Received: from forward2h.mail.yandex.net (forward2h.mail.yandex.net [IPv6:2a02:6b8:0:f05::2]) by mx1.freebsd.org (Postfix) with ESMTP id 0CE04E64; Mon, 25 Feb 2013 05:40:38 +0000 (UTC) Received: from smtp2h.mail.yandex.net (smtp2h.mail.yandex.net [84.201.187.145]) by forward2h.mail.yandex.net (Yandex) with ESMTP id E13A17006EA; Mon, 25 Feb 2013 09:40:35 +0400 (MSK) Received: from smtp2h.mail.yandex.net (localhost [127.0.0.1]) by smtp2h.mail.yandex.net (Yandex) with ESMTP id 2879A17004B8; Mon, 25 Feb 2013 09:40:35 +0400 (MSK) Received: from ip-86-110-189-214.spark-rostov.ru (ip-86-110-189-214.spark-rostov.ru [86.110.189.214]) by smtp2h.mail.yandex.net (nwsmtp/Yandex) with ESMTP id eYXuDme6-eYXCrJYb; Mon, 25 Feb 2013 09:40:34 +0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1361770835; bh=mSotX75UBTYP9sq38MzPJqUoxzh7P9pjlXa/49fsjv8=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=cLW7ao6C8Z24u0NBmrZvossWuNfw50aD5U+qgZGUP1zH1R3EzSpSm1Xrq80OZ+PXo NdzfcmmCxVipkaJ3ayTArycXCjX/GlSwA4kf9BQrcF8ee1wgOUO128uwJalISmKaQq T0vTT7eUJ3Zi+oqxWlQkaGk/pZ8aZajpvSB4zMRE= Message-ID: <512AF924.40504@yandex.ru> Date: Mon, 25 Feb 2013 09:39:48 +0400 From: Ruslan Makhmatkhanov User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130225 Thunderbird/17.0.3 MIME-Version: 1.0 To: araujo@FreeBSD.org Subject: Re: svn commit: r312904 - head/net-im/imspector References: <201302250425.r1P4Pc9u020378@svn.freebsd.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Araujo , svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Po-Chien Lin , ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Feb 2013 05:40:38 -0000 Hi, Marcelo Araujo wrote on 25.02.2013 08:35: > 2013/2/25 Po-Chien Lin > >> Author: pclin >> Date: Mon Feb 25 04:25:37 2013 >> New Revision: 312904 >> URL: http://svnweb.freebsd.org/changeset/ports/312904 >> >> Log: >> - Add IPFW suuport [1] and enable it by default [2] >> - Trim Makefile header [2] >> - Remove invalid entry from MASTER_SITES >> - Patch to fix clang compiling >> - Tune pkg-plist to pet portlint(1) >> >> PR: ports/175765 >> Submitted by: Oleg_Sch <7zsfx@7zsfx.info> [1] >> Approved by: Mikhail Tsatsenko (maintainer) [2] >> Approved by: swills (mentor) >> >> > Dear Po-Chien, > > For my eyes, it is pretty much strange when we have two lines of "Approved > by" or more then one line of Submitted by or wherever, usually we use only > one line, and something like bellow: > > Approve by: Mikhail Tsatsenko (maintainer) > swills (mentor) > > An example to submit: > > PR: ports/1111 [1], ports/22222 [2], ports/33333 [3] Will this line be expanded up to three gnats followups (with commit message) for three different pr's? If I recall correctly it was suggested to use exactly this form to make sure everything is right: PR: ports/1111 [1] PR: ports/22222 [2] PR: ports/33333 [3] And I stick this style because of that reason. Can anybody clarify (once again)? -- Regards, Ruslan Tinderboxing kills... the drives.