From owner-svn-src-head@FreeBSD.ORG Mon May 17 20:06:18 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8A876106564A; Mon, 17 May 2010 20:06:18 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 5CDD68FC08; Mon, 17 May 2010 20:06:18 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 3F1C846B58; Mon, 17 May 2010 16:06:16 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 3F1B68A021; Mon, 17 May 2010 16:06:15 -0400 (EDT) From: John Baldwin To: src-committers@freebsd.org Date: Mon, 17 May 2010 15:47:40 -0400 User-Agent: KMail/1.12.1 (FreeBSD/7.3-CBSD-20100217; KDE/4.3.1; amd64; ; ) References: <201005171936.o4HJauI8018586@svn.freebsd.org> In-Reply-To: <201005171936.o4HJauI8018586@svn.freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201005171547.40705.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Mon, 17 May 2010 16:06:15 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r208212 - head/sys/net X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 May 2010 20:06:18 -0000 On Monday 17 May 2010 3:36:56 pm John Baldwin wrote: > Author: jhb > Date: Mon May 17 19:36:56 2010 > New Revision: 208212 > URL: http://svn.freebsd.org/changeset/base/208212 > > Log: > Ignore failures from removing multicast addresses from the parent (trunk) > interface when tearing down a vlan interface. If a trunk interface is > detached, all of its multicast addresses are removed before the ifnet > departure eventhandlers are invoked. This means that all of the multicast > addresses are removed before the vlan interfaces are removed which causes > the if_delmulti() calls in the vlan teardown to fail. > > In the VLAN_ARRAY case, this left vlan interfaces referencing a no longer > valid parent interface. In the !VLAN_ARRAY case, the eventhandler gets > stuck in an infinite loop retrying vlan_unconfig_locked() forever. In > general the callers of vlan_unconfig_locked() do not expect nor handle > failure, so I believe it is safer to ignore the errors and tear down as > much of the vlan state as possible. The infinite loop is reproducible by doing something like: ifconfig cxgb0.100 create <.. configure cxgb0.100 ..> <.. listen for multicast on cxgb0.100 ..> kldunload if_cxgb.ko In 7 the infinite loop occurs under Giant which causes maximum fun as ptys for sshd need Giant still in 7. -- John Baldwin