From owner-svn-src-all@freebsd.org Sat Aug 24 18:50:30 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C5D7EC7042; Sat, 24 Aug 2019 18:50:30 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-io1-f44.google.com (mail-io1-f44.google.com [209.85.166.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46G6lp4ry0z40XC; Sat, 24 Aug 2019 18:50:30 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-io1-f44.google.com with SMTP id s21so27940254ioa.1; Sat, 24 Aug 2019 11:50:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=9l6eI3fzdgyA6+MNnAPvMTchwPsf5g/z+V8G19T6h0I=; b=QUtqTELPCMzmZaDad5HvkOOytB/YivysvRdpuphhpumbnLaAe97uxSvfl7dWX+UMHi wag1JfK2FF/fkAloBq27V2pcyt6uCr0N+Wq722eg6aLplgFKETiRx7Sr4SIlVjQCtMyM D7dDF7gHMQkdsxdiorT3pFMtScUtveOUiSSaXUg6S3dDxHOEt6c7tLFLFvsSINRkWpua MxuuE2zYPSd7fUG37/FEHS6N8EqRdPBvtKUCh16sToBNhFYQofYV/Rzmk3cmCvRPLn2Q X84sdiZQUftF2mFotq+hqe9KE7TZAmPIJR/GKwxO8cAB4ZjD+xra03sbDbWKuM/K1PkO xPeA== X-Gm-Message-State: APjAAAVZGwl1Ivy1dvSa+xJr/f2Bxz0rDPqre/mor22jNWe8NSaTQKQK o/tGIJk4NDDf2h7A3JKQZlLS7PdG X-Google-Smtp-Source: APXvYqyJ5q+2d8NC55MgBeBBtqg/NR/Boe5YlZbPq+gGzT5yr+3/L40y5obx7GTIKJAM2WXtnK9YJw== X-Received: by 2002:a5e:d911:: with SMTP id n17mr2384509iop.32.1566672629496; Sat, 24 Aug 2019 11:50:29 -0700 (PDT) Received: from mail-io1-f49.google.com (mail-io1-f49.google.com. [209.85.166.49]) by smtp.gmail.com with ESMTPSA id l6sm4677845ioc.15.2019.08.24.11.50.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 24 Aug 2019 11:50:29 -0700 (PDT) Received: by mail-io1-f49.google.com with SMTP id t3so27770128ioj.12; Sat, 24 Aug 2019 11:50:29 -0700 (PDT) X-Received: by 2002:a5d:93c4:: with SMTP id j4mr4567964ioo.80.1566672628950; Sat, 24 Aug 2019 11:50:28 -0700 (PDT) MIME-Version: 1.0 References: <201908241550.x7OFoD80037926@repo.freebsd.org> In-Reply-To: <201908241550.x7OFoD80037926@repo.freebsd.org> Reply-To: cem@freebsd.org From: Conrad Meyer Date: Sat, 24 Aug 2019 11:50:18 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r351459 - head/usr.bin/last To: Eugene Grosbein Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 46G6lp4ry0z40XC X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.976,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Aug 2019 18:50:30 -0000 Hi Eugene, This change introduced some style(9) violations. On Sat, Aug 24, 2019 at 8:50 AM Eugene Grosbein wrote: > > Author: eugen > Date: Sat Aug 24 15:50:13 2019 > New Revision: 351459 > URL: https://svnweb.freebsd.org/changeset/base/351459 > ... > --- head/usr.bin/last/last.c Sat Aug 24 15:38:07 2019 (r351458) > +++ head/usr.bin/last/last.c Sat Aug 24 15:50:13 2019 (r351459) > ... > @@ -158,7 +158,9 @@ main(int argc, char *argv[]) > d_first = (*nl_langinfo(D_MD_ORDER) == 'd'); > > (void) setlocale(LC_CTYPE, ""); > - utf8flag = (strcmp(nl_langinfo(CODESET), "UTF-8") == 0); > + p = nl_langinfo(CODESET); > + if (strcmp (p, "UTF-8") == 0 || strcmp (p, "US-ASCII") == 0) > + noctfix = 1; There are extraneous spaces between strcmp and '('. Best, Conrad