From owner-freebsd-bugs Wed Mar 17 1: 0:20 1999 Delivered-To: freebsd-bugs@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (Postfix) with ESMTP id B95C615617 for ; Wed, 17 Mar 1999 01:00:19 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.9.2/8.9.2) id BAA75874; Wed, 17 Mar 1999 01:00:01 -0800 (PST) (envelope-from gnats@FreeBSD.org) Date: Wed, 17 Mar 1999 01:00:01 -0800 (PST) Message-Id: <199903170900.BAA75874@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: bmah@ca.sandia.gov Subject: bin/10633: [patch] tcpslice timezone problem and update/contribify/fix Reply-To: bmah@ca.sandia.gov Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org The following reply was made to PR bin/10633; it has been noted by GNATS. From: bmah@ca.sandia.gov To: FreeBSD-gnats-submit@freebsd.org Cc: Subject: bin/10633: [patch] tcpslice timezone problem and update/contribify/fix Date: Tue, 16 Mar 1999 20:56:56 -0800 (PST) >Number: 10633 >Category: bin >Synopsis: [patch] tcpslice timezone problem and update/contribify/fix >Confidential: no >Severity: serious >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Mar 16 21:00:02 PST 1999 >Closed-Date: >Last-Modified: >Originator: Bruce A. Mah >Release: FreeBSD 3.1-RELEASE i386 >Organization: Sandia National Laboratories >Environment: >Description: The version of tcpslice in the source tree has a few problems related to how it interprets temporal arguments. It appears to be doing timezone conversions wrong. >How-To-Repeat: With a "tcpdump -w" file, try subsetting parts of the file. The examples below were attempts to get all packets in a 24-hour time window, starting at 2 AM the morning after a trace started. Wrong behavior: eisenhower:tcpslice% tcpslice -d -r 2h +24h tcpdump.out tcpdump.out Fri Mar 12 16:24:00 1999 Mon Mar 15 09:50:18 1999 start Thu Mar 11 18:00:00 1999 stop Fri Mar 12 10:00:00 1999 Correct behavior: eisenhower:tcpslice% ./tcpslice -d -r 2h +24h tcpdump.out tcpdump.out Fri Mar 12 16:24:00 1999 Mon Mar 15 09:50:18 1999 start Fri Mar 12 02:00:00 1999 stop Sat Mar 13 02:00:00 1999 >Fix: Pursuant to ports/9358, the idea was discussed of importing a newer tcpslice into the source tree. A newer version from LBL fixes the problem above. I think it'd also be appropriate to move the distribution of tcpslice into /usr/src/contrib, to parallel the location of tcpdump. I think the steps needed are these: 1. Grab ftp://ftp.ee.lbl.gov/tcpslice-1.1a3.tar.Z. Unpack it, and make the resulting directory /usr/src/contrib/tcpslice. 2. cvs remove all of the files in /usr/src/usr.sbin/tcpdump/tcpslice except for the Makefile. 3. New /usr/src/usr.sbin/tcpdump/tcpslice/Makefile is uuencoded and enclosed below. (No diffs sent since the two Makefiles don't have much in common.) begin 644 Makefile M(PDD260D"@I04D]'/0ET8W!S;&EC90I#1DQ!1U,K/2U$2$%615]&0TY43%]( M/3$@+41424U%7U=)5$A?4UE37U1)344],2`M1$A!5D5?5D904DE.5$8],0I- M04XQ/0ET8W!S;&EC92XQ"E-20U,@/0EV97)S:6]N+F,@=&-PTQ)0E!# M05!]"DQ$041$*ST)+6QP8V%P"@I40U!33$E#15]$25-41$E2/ST@)'LN0U52 M1$E2?2\N+B\N+B\N+B]C;VYTRelease-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message