From owner-cvs-ports@FreeBSD.ORG Mon Nov 28 08:24:14 2005 Return-Path: X-Original-To: cvs-ports@FreeBSD.org Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DC61216A41F; Mon, 28 Nov 2005 08:24:14 +0000 (GMT) (envelope-from edwin@mavetju.org) Received: from mail3out.barnet.com.au (mail3out.barnet.com.au [202.83.176.17]) by mx1.FreeBSD.org (Postfix) with ESMTP id 34E2043D49; Mon, 28 Nov 2005 08:24:14 +0000 (GMT) (envelope-from edwin@mavetju.org) Received: by mail3out.barnet.com.au (Postfix, from userid 27) id 460FC877C9D; Mon, 28 Nov 2005 19:24:13 +1100 (EST) X-Viruscan-Id: <438ABEAD0000E1B70D4008@BarNet> Received: from mail3-auth.barnet.com.au (mail3.barnet.com.au [202.83.176.16]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.barnet.com.au", Issuer "BarNet Root Certificate Authority" (verified OK)) by mail3.barnet.com.au (Postfix) with ESMTP id 1FED3877C94; Mon, 28 Nov 2005 19:24:13 +1100 (EST) Received: from k7.mavetju (edwin-3.int.barnet.com.au [10.10.12.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "edwin.adsl.barnet.com.au", Issuer "BarNet Root Certificate Authority" (not verified)) by mail3-auth.barnet.com.au (Postfix) with ESMTP id A99C7877C91; Mon, 28 Nov 2005 19:24:12 +1100 (EST) Received: by k7.mavetju (Postfix, from userid 1001) id EB06F62B0; Mon, 28 Nov 2005 19:24:10 +1100 (EST) Date: Mon, 28 Nov 2005 19:24:10 +1100 From: Edwin Groothuis To: Kris Kennaway Message-ID: <20051128082410.GO1265@k7.mavetju> References: <200511280557.jAS5va2I051976@repoman.freebsd.org> <20051128061137.GA11774@xor.obsecurity.org> <20051128075604.GM1239@k7.mavetju> <20051128080208.GA14243@xor.obsecurity.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20051128080208.GA14243@xor.obsecurity.org> User-Agent: Mutt/1.5.9i Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/misc Makefile ports/misc/instant-tinderbox Makefile pkg-descr X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Nov 2005 08:24:15 -0000 On Mon, Nov 28, 2005 at 03:02:09AM -0500, Kris Kennaway wrote: > On Mon, Nov 28, 2005 at 06:56:04PM +1100, Edwin Groothuis wrote: > > On Mon, Nov 28, 2005 at 01:11:37AM -0500, Kris Kennaway wrote: > > > I think this port is a bad idea. It'll take a fairly long time to > > > build on pointyhat from all the pkg_adds (and it will be right at the > > > end of the package builds since it depends on everything else, so the > > > whole build will end up waiting for it), and it's not useful for > > > anyone apart from users of marcus' tinderbox scripts. Therefore it > > > should be reimplemented there instead. > > > > If I add a .ifdef to it which prevents it from being attempted to > > build on non-tinderbox systems, is that a good solution? Or does > > the packaging system ignore IGNOREs? > > No, it respects IGNORE..but I still don't see why it should be a port > instead of a small shell script included with the tinderbox. Because a port understands that if I do USE_OPENLDAP, it will come up with the version of net/openldap which is currently defined in the ports framework, and if I do USE_PGSQL, it will come up with the version of databases/pgsql-xx-server which is currently defined in the ports framework. With an external script I have to somehow find out what the current versions for the USE_OPENLDAP and USE_PGSQL variables are. And besides invoken the powers of Make I have no idea how to do it properly. Edwin -- Edwin Groothuis | Personal website: http://www.mavetju.org edwin@mavetju.org | Weblog: http://weblog.barnet.com.au/edwin/