From owner-freebsd-hackers@FreeBSD.ORG  Mon Jan 26 14:31:10 2004
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5F76916A4CE
	for <hackers@freebsd.org>; Mon, 26 Jan 2004 14:31:10 -0800 (PST)
Received: from web40304.mail.yahoo.com (web40304.mail.yahoo.com
	[66.218.78.83])	by mx1.FreeBSD.org (Postfix) with SMTP id 826C943D39
	for <hackers@freebsd.org>; Mon, 26 Jan 2004 14:31:07 -0800 (PST)
	(envelope-from m_evmenkin@yahoo.com)
Message-ID: <20040126223107.64659.qmail@web40304.mail.yahoo.com>
Received: from [66.35.239.94] by web40304.mail.yahoo.com via HTTP;
	Mon, 26 Jan 2004 14:31:07 PST
Date: Mon, 26 Jan 2004 14:31:07 -0800 (PST)
From: Maksim Yevmenkin <m_evmenkin@yahoo.com>
To: current@freebsd.org, hackers@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailman-Approved-At: Tue, 27 Jan 2004 05:29:37 -0800
cc: imp@freebsd.org
Subject: [PATCH] libusbhid(3)  should not clear report_size field
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Jan 2004 22:31:10 -0000

Dear Hackers,

while working on bluetooth hid implementation i found out that
libusbhid(3) has minor problem. it turns out that netbsd folks
already fixed this.

http://cvsweb.netbsd.org/bsdweb.cgi/src/lib/libusbhid/parse.c.diff?sortby=date&r1=1.4&r2=1.5&f=u

so, i'd like to commit the patch below. who is our resident USB
HID expert? please speak up if there is any problem, concern or
objection.

thanks,
max

freefall% scvs diff -u src/lib/libusbhid
cvs server: Diffing src/lib/libusbhid
Index: src/lib/libusbhid/parse.c
===================================================================
RCS file: /home/ncvs/src/lib/libusbhid/parse.c,v
retrieving revision 1.8
diff -u -r1.8 parse.c
--- src/lib/libusbhid/parse.c   9 Apr 2003 01:52:48 -0000       1.8
+++ src/lib/libusbhid/parse.c   26 Jan 2004 22:25:26 -0000
@@ -86,7 +86,6 @@
        c->string_minimum = 0;
        c->string_maximum = 0;
        c->set_delimiter = 0;
-       c->report_size = 0;
 }
 
 hid_data_t


__________________________________
Do you Yahoo!?
Yahoo! SiteBuilder - Free web site building tool. Try it!
http://webhosting.yahoo.com/ps/sb/