From nobody Fri Jun 26 16:48:18 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gn1p02Lfrz6jmCT for ; Fri, 26 Jun 2026 16:48:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gn1nz6FZNz4BGm for ; Fri, 26 Jun 2026 16:48:23 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782492503; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SLYSc4MiJDBoaE8T8LkrHZyjvClDrI7OMGvIg2fKt+s=; b=eIvvErIowGMunxQNNrJYOJNfTR4xezjt3mlWCs+CN8+Pa2cJIBS1hkt5B9N44zJez3+4D2 DKAQF+myUAev196caAMLqV46Es59ofLAJ5IWEjHdo7VYtb5MAXTeU8Gp9msOTdjt9q1+6N 8/DIbpZYhzEwpQ14QGt0sVLRUmss/Yt4lA/yb6TmxFnwWE2oiR6HMZmQ4glp0+7QWyF3No UXC/pc+Cd7KZ0NPJWNUmf3gouzGDbiTAfj4wSOIjrZTvZgLhVml4IoktANQHdchjQ9SZbH 0QzEYX1Po/wkG5crW1aJ8BvHchqR4HXjYcVj3gXHkqobQgqMZAQIXNcL9Si8ng== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782492503; a=rsa-sha256; cv=none; b=E9Bs8skFI4tK4bDb797pHMa9aenazDPI5PE4ckwY66h4dbk1dOWXFfOSWnbACVF3jP4eHG 3SGjxRuHB+T6qXUudI0I0OhA67VBzHwlWlBHpGsx6a836mLK3dXdPzJIjw9LovcT/Btl+s U1vOc/KF225tdThdO0promssK2oo5Mp+UiDrSkd7i18AcypOy/R2KfQLnFgfTXzO9j1+Em btOoXz3gxVBSCJe/TQL96IFRy/OXlV8inXIJvANtMiuVuW2Z2NH//7UMKWuvT5YlupbSp2 G85KQBUFBGsmVqIVJrYNvNTDhWmVCDyy70pHQpfwAWvX/hMGbYfbq35az+y2ZA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782492503; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=SLYSc4MiJDBoaE8T8LkrHZyjvClDrI7OMGvIg2fKt+s=; b=YT4uV6AsJ+sIa0FTmIo2FkfsjNBQt9xvgK6pjH/AqSz6R6cSE+YyX7zLeEB7apYvuVPPHY gaSndE06bX0idJRSJk5USYlNsyWcgo7Bm16W9pUvQcS2va1BxGfN5oKcKPF0YHVdTVNuzr P4CIO2W++1qf1iNMs94/PdY9IXhTDFTWDbK1UDebmT48kY+BYdhPYotPW0iWvhMPXGy5nJ tU3UWaHp0WSElK3EMlLoTLnKV3Nl7B3j91imlJJmFTbjOCpAoJNSqCa/PEVC90HqlCGF0p nN/i3M8oKx7SoUaKJw3zvvPxc0HPwqEGWMdpBufLlIMAkm7pm3abffxr62cUlQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gn1nz4N2pzlCF for ; Fri, 26 Jun 2026 16:48:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3187d by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 26 Jun 2026 16:48:18 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Brooks Davis Subject: git: 2515e3f6776a - main - cdefs(9): encourage __nodiscard over __result_use_check List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: brooks X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2515e3f6776a3f95c888be5e58b28df0ffbe3dd8 Auto-Submitted: auto-generated Date: Fri, 26 Jun 2026 16:48:18 +0000 Message-Id: <6a3ead52.3187d.dba871d@gitrepo.freebsd.org> The branch main has been updated by brooks: URL: https://cgit.FreeBSD.org/src/commit/?id=2515e3f6776a3f95c888be5e58b28df0ffbe3dd8 commit 2515e3f6776a3f95c888be5e58b28df0ffbe3dd8 Author: Brooks Davis AuthorDate: 2026-06-26 16:41:40 +0000 Commit: Brooks Davis CommitDate: 2026-06-26 16:41:40 +0000 cdefs(9): encourage __nodiscard over __result_use_check __nodiscard is closer to (and sometimes expands to) [[nodiscard]] from C23 and C++17 so prefer it to the homegrown __result_use_check. When __nodiscard does expand to [[nodiscard]] it must appear entierly before the function declaration (or between the function name and argument list) so relocate as appropriate. This differs from __attribute__((__warn_unused_result__)) used by __result_use_check which is more flexible. Reviewed by: imp, markj, emaste Sponsored by: DARPA, AFRL Differential Revision: https://reviews.freebsd.org/D57881 --- share/man/man9/cdefs.9 | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/share/man/man9/cdefs.9 b/share/man/man9/cdefs.9 index 2bda50c3f875..9edfeec70bc6 100644 --- a/share/man/man9/cdefs.9 +++ b/share/man/man9/cdefs.9 @@ -3,7 +3,7 @@ .\" .\" SPDX-License-Identifier: BSD-2-Clause .\" -.Dd May 6, 2026 +.Dd June 26, 2026 .Dt CDEFS 9 .Os .Sh NAME @@ -121,6 +121,9 @@ family of functions. .Dq fastcall ABI to call and name mangle this function. .It Sy __result_use_check Ta Warn if function caller does not use its return value +Obsolete, use +.Sy __nodiscard +instead. .It Sy __nodiscard Ta Equivalent to the standard .Dq [[nodiscard]] attribute. @@ -134,6 +137,9 @@ If applied to a struct, C++ class or enum, this applies to all functions returning values of that type. If applied to a C++ constructor, this applies to creating instances of the class using that constructor. +Note that +.Sy __nodiscard +must appear before the function declaration. .It Sy __returns_twice Ta Returns multiple times, like .Xr fork 2 .It Sy __unreachable Ta This code is not reachable at runtime