From nobody Thu Apr 30 17:47:45 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g61pn4kTDz6bw76 for ; Thu, 30 Apr 2026 17:47:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g61pn3fPPz3mG9 for ; Thu, 30 Apr 2026 17:47:45 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777571265; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3aHAqlcnA3m51ZYwwQtOdYhJOe2Zzl0VCVwEvyvVTEY=; b=XkeDN0fgmfkV8NDIPaShilzpWbtJLa4eKTCGCyqR6S1uaTodrVWR5SCDTkidvD7kbV2SU9 eT7jrZRIyayKOldEAUM37vxnMknxzn8hUvq50eLZMrMU4oYBRDOY65f2skeiz0xERv0MBO pQqEvuGAXE7BXkjhMLhQVKcyaT1HTPW58l2/qPXAJVsmKaUH8Hy6ORvp0DKnrMkTO4zBns QiQMfSQoIzt5wpxx6YoRR9POdFbXsMlfRPJ6+8E4KsiYdmxLE506+8IeJFPlbJwEzFWOu7 jbZaACDk8QnBRQuwXdUB4YJptBGxaWtpZHnC3n+gjzeJ8mE+pz0LK7SP8mAljQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1777571265; a=rsa-sha256; cv=none; b=TeKO5tnahnrwfeVLXlqQR80CdEQQ3xRYV6NZngXAU9lNrbWRteA7FJt7Gqm+J/cfrtNduA biinyx0J0iWx1UO9n30nWazoQ9omFPTfewnbrvSOrmkzb/fYSkm94EU/l5CPsyS+CBioTq 5F3Vk1RCST4rezr7tH57hg6a78reo2TqrndKcfYFl6v1MGId/k+Q3UaBIsiIe87/bTxqs/ s4aqCd1stHLONinCUGrkqJ3XBqX9CyKpCsqUhkhJmmz2mQpm+Ne8mNmHmHFVGtzQ7xRFXR AG5+3gsptwfEWlA+vK9yagha0r0DBoKP+25OWYw8yWdmpeSTNCihIYf9kmEPdQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777571265; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3aHAqlcnA3m51ZYwwQtOdYhJOe2Zzl0VCVwEvyvVTEY=; b=Sa3Yvey/FXz6MbGOiolRCsN/w2I9AqnxR0J7a/sf6OVUYba5k8mLWye9c0u0RqmmiCoyyH YfWQX5SxZAPm9JVlj4dKcRguiboLlGkateWcbO+KmKrkB2IYsN83sOMT60+etiCZUEznOY 9S4L0YbCfPLLK5LgfU0o9kdKhN68BMNmZB3KunKKxrHMEpvxuvGU8pInHQ1j5Do4hkulWD BRujIsg91ZXGxJkaar4zBPGIY8LEQ12SKhCpj8LhQEvNFN11L0QWXgG4aGocqT3pLAwrUO kEj0tKsDYfab0v66uzAygNY98iyCdh0dquHf/pHv/zyNh5NH5nLFRQuWYwdfVg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g61pn36FYz6dD for ; Thu, 30 Apr 2026 17:47:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3158d by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 30 Apr 2026 17:47:45 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: David Arinzon From: Colin Percival Subject: git: 3394b3acbd70 - stable/15 - ena: Report RX overrun errors List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cperciva X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 3394b3acbd70b6ebc7a6c725e96c1e9efb0b0e0c Auto-Submitted: auto-generated Date: Thu, 30 Apr 2026 17:47:45 +0000 Message-Id: <69f395c1.3158d.7949b3a5@gitrepo.freebsd.org> The branch stable/15 has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=3394b3acbd70b6ebc7a6c725e96c1e9efb0b0e0c commit 3394b3acbd70b6ebc7a6c725e96c1e9efb0b0e0c Author: David Arinzon AuthorDate: 2026-04-15 12:13:56 +0000 Commit: Colin Percival CommitDate: 2026-04-30 17:47:07 +0000 ena: Report RX overrun errors Extract rx_overruns from the keep alive descriptor reported by the device and expose it via sysctl hw stats. RX overrun errors occur when a packet arrives but there are not enough free buffers in the RX ring to receive it. MFC after: 2 weeks Sponsored by: Amazon, Inc. Differential Revision: https://reviews.freebsd.org/D56640 (cherry picked from commit e3f4a63af63bea70bc86b6c790b14aa5ee99fcd0) --- sys/dev/ena/ena.c | 4 ++++ sys/dev/ena/ena.h | 2 ++ sys/dev/ena/ena_sysctl.c | 2 ++ 3 files changed, 8 insertions(+) diff --git a/sys/dev/ena/ena.c b/sys/dev/ena/ena.c index eddb7dbd42e8..b91fade61cec 100644 --- a/sys/dev/ena/ena.c +++ b/sys/dev/ena/ena.c @@ -3090,15 +3090,19 @@ ena_keep_alive_wd(void *adapter_data, struct ena_admin_aenq_entry *aenq_e) sbintime_t stime; uint64_t rx_drops; uint64_t tx_drops; + uint64_t rx_overruns; desc = (struct ena_admin_aenq_keep_alive_desc *)aenq_e; rx_drops = ((uint64_t)desc->rx_drops_high << 32) | desc->rx_drops_low; tx_drops = ((uint64_t)desc->tx_drops_high << 32) | desc->tx_drops_low; + rx_overruns = ((uint64_t)desc->rx_overruns_high << 32) | desc->rx_overruns_low; counter_u64_zero(adapter->hw_stats.rx_drops); counter_u64_add(adapter->hw_stats.rx_drops, rx_drops); counter_u64_zero(adapter->hw_stats.tx_drops); counter_u64_add(adapter->hw_stats.tx_drops, tx_drops); + counter_u64_zero(adapter->hw_stats.rx_overruns); + counter_u64_add(adapter->hw_stats.rx_overruns, rx_overruns); stime = getsbinuptime(); atomic_store_rel_64(&adapter->keep_alive_timestamp, stime); diff --git a/sys/dev/ena/ena.h b/sys/dev/ena/ena.h index b2156437f847..8b5bcdc3214f 100644 --- a/sys/dev/ena/ena.h +++ b/sys/dev/ena/ena.h @@ -417,6 +417,8 @@ struct ena_hw_stats { counter_u64_t rx_drops; counter_u64_t tx_drops; + + counter_u64_t rx_overruns; }; /* Board specific private data structure */ diff --git a/sys/dev/ena/ena_sysctl.c b/sys/dev/ena/ena_sysctl.c index 38e52f9066cc..a46119e06adf 100644 --- a/sys/dev/ena/ena_sysctl.c +++ b/sys/dev/ena/ena_sysctl.c @@ -419,6 +419,8 @@ ena_sysctl_add_stats(struct ena_adapter *adapter) &hw_stats->rx_drops, "Receive packet drops"); SYSCTL_ADD_COUNTER_U64(ctx, hw_list, OID_AUTO, "tx_drops", CTLFLAG_RD, &hw_stats->tx_drops, "Transmit packet drops"); + SYSCTL_ADD_COUNTER_U64(ctx, hw_list, OID_AUTO, "rx_overruns", CTLFLAG_RD, + &hw_stats->rx_overruns, "Receive overruns"); /* ENA Admin queue stats */ admin_node = SYSCTL_ADD_NODE(ctx, child, OID_AUTO, "admin_stats",