From owner-freebsd-multimedia@FreeBSD.ORG Wed Apr 23 09:46:29 2008 Return-Path: Delivered-To: freebsd-multimedia@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BBEE9106564A; Wed, 23 Apr 2008 09:46:29 +0000 (UTC) (envelope-from miwi@bsdcrew.de) Received: from bsdcrew.de (duro.unixfreunde.de [85.214.90.4]) by mx1.freebsd.org (Postfix) with ESMTP id 81C8C8FC12; Wed, 23 Apr 2008 09:46:29 +0000 (UTC) (envelope-from miwi@bsdcrew.de) Received: by bsdcrew.de (Postfix, from userid 1001) id C1B904AC8D; Wed, 23 Apr 2008 11:46:23 +0200 (CEST) Date: Wed, 23 Apr 2008 11:46:23 +0200 From: Martin Wilke To: Coleman Kane Message-ID: <20080423094623.GE69856@bsdcrew.de> References: <1208876296.3060.14.camel@localhost> <20080422154130.GA60817@bsdcrew.de> <1208882246.1320.0.camel@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; x-action=pgp-signed Content-Disposition: inline In-Reply-To: <1208882246.1320.0.camel@localhost> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: freebsd-multimedia@FreeBSD.org Subject: Re: Update to multimedia/transcode broke ImageMagick X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Apr 2008 09:46:29 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Tue, Apr 22, 2008 at 12:37:26PM -0400, Coleman Kane wrote: > On Tue, 2008-04-22 at 17:41 +0200, Martin Wilke wrote: > > -----BEGIN PGP SIGNED MESSAGE----- > > Hash: SHA1 > > > > On Tue, Apr 22, 2008 at 10:58:16AM -0400, Coleman Kane wrote: > > > Hi, > > > > > > The upgrade of ImageMagick breaks the ability for transcode to build > > > WTIH_IMAGEMAGICK=yes, even more than the small Makefile change it > > > recently experienced. > > > > > > It seems that the configure script is still looking for libMagick.so > > > (instead of libMagickCore.so or libMagickWand.so). > > > > > > Additionally, the following: > > > > > > .if (defined(WITH_IMAGEMAGICK) || exists(${LOCALBASE}/lib/libMagick.so)) && !defined(WITHOUT_IMAGEMAGICK) > > > LIB_DEPENDS+= MagickWand.1:${PORTSDIR}/graphics/ImageMagick > > > CONFIGURE_ARGS+= --enable-imagemagick --with-imagemagick-prefix=${LOCALBASE} > > > .else > > > CONFIGURE_ARGS+= --enable-imagemagick=no > > > .endif > > > > > > Should be changed to: > > > > > > .if (defined(WITH_IMAGEMAGICK) || exists(${LOCALBASE}/lib/libMagickWand.so)) && !defined(WITHOUT_IMAGEMAGICK) > > > LIB_DEPENDS+= MagickWand.1:${PORTSDIR}/graphics/ImageMagick > > > CONFIGURE_ARGS+= --enable-imagemagick --with-imagemagick-prefix=${LOCALBASE} > > > .else > > > CONFIGURE_ARGS+= --enable-imagemagick=no > > > .endif > > > > You are right. Fixed. > > > > > > > > (The exists(...) clause needs to mimic the change on LIB_DEPENDS+= ) > > > > > > -- > > > Coleman Kane > > And the bug in the configure script? > Hi, Can you please test follow patch: http://miwi.homeunix.com/tc.diff Thanks Martin > -- > Coleman Kane - -- +-----------------------+-------------------------------+ | PGP : 0x05682353 | Jabber : miwi(at)BSDCrew.de | | ICQ : 169139903 | Mail : miwi(at)FreeBSD.org | +-----------------------+-------------------------------+ | Mess with the Best, Die like the Rest! | +-----------------------+-------------------------------+ -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFIDwVvFwpycAVoI1MRAg0dAJ907lYguHwhdiIF4AG2YBIhLFjL9ACfdRHc OVUTTXjSJiaKZ/tUkHT3sWo= =21kX -----END PGP SIGNATURE-----