Date: Wed, 23 Apr 2008 11:46:23 +0200 From: Martin Wilke <miwi@FreeBSD.org> To: Coleman Kane <cokane@FreeBSD.org> Cc: freebsd-multimedia@FreeBSD.org Subject: Re: Update to multimedia/transcode broke ImageMagick Message-ID: <20080423094623.GE69856@bsdcrew.de> In-Reply-To: <1208882246.1320.0.camel@localhost> References: <1208876296.3060.14.camel@localhost> <20080422154130.GA60817@bsdcrew.de> <1208882246.1320.0.camel@localhost>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Tue, Apr 22, 2008 at 12:37:26PM -0400, Coleman Kane wrote:
> On Tue, 2008-04-22 at 17:41 +0200, Martin Wilke wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > On Tue, Apr 22, 2008 at 10:58:16AM -0400, Coleman Kane wrote:
> > > Hi,
> > >
> > > The upgrade of ImageMagick breaks the ability for transcode to build
> > > WTIH_IMAGEMAGICK=yes, even more than the small Makefile change it
> > > recently experienced.
> > >
> > > It seems that the configure script is still looking for libMagick.so
> > > (instead of libMagickCore.so or libMagickWand.so).
> > >
> > > Additionally, the following:
> > >
> > > .if (defined(WITH_IMAGEMAGICK) || exists(${LOCALBASE}/lib/libMagick.so)) && !defined(WITHOUT_IMAGEMAGICK)
> > > LIB_DEPENDS+= MagickWand.1:${PORTSDIR}/graphics/ImageMagick
> > > CONFIGURE_ARGS+= --enable-imagemagick --with-imagemagick-prefix=${LOCALBASE}
> > > .else
> > > CONFIGURE_ARGS+= --enable-imagemagick=no
> > > .endif
> > >
> > > Should be changed to:
> > >
> > > .if (defined(WITH_IMAGEMAGICK) || exists(${LOCALBASE}/lib/libMagickWand.so)) && !defined(WITHOUT_IMAGEMAGICK)
> > > LIB_DEPENDS+= MagickWand.1:${PORTSDIR}/graphics/ImageMagick
> > > CONFIGURE_ARGS+= --enable-imagemagick --with-imagemagick-prefix=${LOCALBASE}
> > > .else
> > > CONFIGURE_ARGS+= --enable-imagemagick=no
> > > .endif
> >
> > You are right. Fixed.
> >
> > >
> > > (The exists(...) clause needs to mimic the change on LIB_DEPENDS+= )
> > >
> > > --
> > > Coleman Kane
>
> And the bug in the configure script?
>
Hi,
Can you please test follow patch:
http://miwi.homeunix.com/tc.diff
Thanks Martin
> --
> Coleman Kane
- --
+-----------------------+-------------------------------+
| PGP : 0x05682353 | Jabber : miwi(at)BSDCrew.de |
| ICQ : 169139903 | Mail : miwi(at)FreeBSD.org |
+-----------------------+-------------------------------+
| Mess with the Best, Die like the Rest! |
+-----------------------+-------------------------------+
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4 (FreeBSD)
iD8DBQFIDwVvFwpycAVoI1MRAg0dAJ907lYguHwhdiIF4AG2YBIhLFjL9ACfdRHc
OVUTTXjSJiaKZ/tUkHT3sWo=
=21kX
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080423094623.GE69856>