From owner-svn-src-head@freebsd.org  Sat May 14 14:42:57 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 862A4B39E52;
 Sat, 14 May 2016 14:42:57 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from mail.turbocat.net (heidi.turbocat.net [88.198.202.214])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4F5041FDE;
 Sat, 14 May 2016 14:42:56 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from laptop015.home.selasky.org (unknown [62.141.129.119])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id 83E0C1FE023;
 Sat, 14 May 2016 16:42:54 +0200 (CEST)
Subject: Re: svn commit: r299653 -
 head/sys/compat/linuxkpi/common/include/linux
To: John Baldwin <jhb@freebsd.org>
References: <201605131010.u4DAAioY094617@repo.freebsd.org>
 <1651080.VgjHNWYnll@ralph.baldwin.cx>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
From: Hans Petter Selasky <hps@selasky.org>
Message-ID: <c5514a72-1632-99bd-4dde-975830604c06@selasky.org>
Date: Sat, 14 May 2016 16:46:09 +0200
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101
 Thunderbird/45.0
MIME-Version: 1.0
In-Reply-To: <1651080.VgjHNWYnll@ralph.baldwin.cx>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 14 May 2016 14:42:57 -0000

On 05/13/16 20:43, John Baldwin wrote:
> On Friday, May 13, 2016 10:10:44 AM Hans Petter Selasky wrote:
>> @@ -190,6 +258,7 @@
>>  #define	smp_processor_id()	PCPU_GET(cpuid)
>>  #define	num_possible_cpus()	mp_ncpus
>>  #define	num_online_cpus()	mp_ncpus
>> +#define	cpu_has_clflush		(1)
>
> This is only true on amd64.  More accurate would be:
>
> #ifdef __amd64__
> #define cpu_has_clflush (1)
> #elif defined(__i386__)
> #define cpu_has_clflush (cpu_feature & CPUID_CLFSH)
> #else
> #define cpu_has_clflush clflush_not_supported
> #endif
>
> Presumably you aren't planning to restrict all of OFED and drm2 to only
> be used on amd64?
>

I'll handle this on Monday. Thank you for your patch!

--HPS