From owner-cvs-src@FreeBSD.ORG Mon Nov 10 17:30:27 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0578516A4CE; Mon, 10 Nov 2003 17:30:27 -0800 (PST) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 040B043FDF; Mon, 10 Nov 2003 17:30:26 -0800 (PST) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id 540A42ED473; Mon, 10 Nov 2003 17:30:22 -0800 (PST) Date: Mon, 10 Nov 2003 17:30:22 -0800 From: Alfred Perlstein To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20031111013022.GL33733@elvis.mu.org> References: <200311110032.hAB0WkJi073981@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200311110032.hAB0WkJi073981@repoman.freebsd.org> User-Agent: Mutt/1.4.1i Subject: Re: cvs commit: src/sys/nfsclient nfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Nov 2003 01:30:27 -0000 This will allow interested parties to smp'ify NFS, otherwise you need a global lock. It also will allow us to remove a lot of the hacks needed to deal with the fake exclusivity of the locking that was going on here. This could be MFC'd but I don't see the point right now. * Alfred Perlstein [031110 16:33] wrote: > alfred 2003/11/10 16:32:46 PST > > FreeBSD src repository > > Modified files: > sys/nfsclient nfs_vnops.c > Log: > Stop using shared locks for nfs vop locks. > > The reason this was done was to avoid a race to the root when an > NFS server went down. However a semi-recent change to the way that > the kernel's lookup() routine traverses mount points prevents this. > > Rev 1.39 of vfs_lookup.c changed the ordering of locks such that we > aquire a shared lock on the mount point being accessed and then drop > the directory vnode lock before requesting the target lock. > > With that in place we no longer need shared locks for NFS to prevent > race to the root lockups. > > Revision Changes Path > 1.214 +0 -3 src/sys/nfsclient/nfs_vnops.c -- - Alfred Perlstein - Research Engineering Development Inc. - email: bright@mu.org cell: 408-480-4684