From owner-svn-src-head@freebsd.org Tue Apr 25 19:29:03 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 72FDDD50648; Tue, 25 Apr 2017 19:29:03 +0000 (UTC) (envelope-from delphij@gmail.com) Received: from mail-oi0-x235.google.com (mail-oi0-x235.google.com [IPv6:2607:f8b0:4003:c06::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 37EFDCC0; Tue, 25 Apr 2017 19:29:03 +0000 (UTC) (envelope-from delphij@gmail.com) Received: by mail-oi0-x235.google.com with SMTP id w12so72205499oiw.3; Tue, 25 Apr 2017 12:29:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=svozjf1ekSzWNJS3UFfZTYfvNzf2ocD+brmTfiEYasw=; b=EySjX6H6Dt0zkoMhW0auAtWjANY56ZMFPLmamVxSpU+EWV+j7Hise9qzeRI2qA9UXq dRoMaGxFRzMHjF16Q15FVeT6ySfol14diVPptrOSlV7NIX6mMm6OmkZwziTd+ACNYXnd zUpoVcOpgOS8DtSN0Z/zwbX5AbPturcmvVQD7u6J+MSaKvBty+oJutSCUirEs0xWhmB2 XcFP+14SAXrBN5naTEzjcKBSP2KI0GjLuc1pqv2EscatQGRm5Avvhuo2ZGbJK8mXHU0I q/eJt+DXsyu+Llq/HNkklSXbWlXGhybrRDXvnQv0AWmE2Mg55eRd3Ym+xzoLx9VwyF4W Mygg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=svozjf1ekSzWNJS3UFfZTYfvNzf2ocD+brmTfiEYasw=; b=ZSQczeBP0ufUO7l+bs2sZBPFBLCtgA8SzXr7SSkVTQHlIWIw+myp8oJc7ED2fd+Z7R 1/+0U2QWnsHAIgJbfZImdSLZYnCEi5B4Q6pgNrJP6Lr39MKiGWLw7sgo5ghZOSZbK07Z I8y8vWOmjD4yADIq3St/usgbPJOebg0h7uSgofp5K5bYCoUiyOeRYkELwZSUm94xFHbl FfAP6C+grQ8sknhRTWY2+XDOjNaNE4xjKVzikcLwjM32CVpiBT53lagJ4qcuoC1xE76J DeCWP4n89YFgCAwYmiMmBISViMfgHz/KKTVotsy3y8ULujE6BnExfkGD8Utxxn0+U4UL cK1Q== X-Gm-Message-State: AN3rC/58OzzFmrShvUVl9JeoTgk4RlHDlxIyrz8AlPUmeSl796Py3Si9 HeBVKsP5OuAekMCMTVjC9uCOs0avsw== X-Received: by 10.202.102.206 with SMTP id m75mr16146770oik.206.1493148542491; Tue, 25 Apr 2017 12:29:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.22.141 with HTTP; Tue, 25 Apr 2017 12:29:01 -0700 (PDT) In-Reply-To: <201704251907.v3PJ7Mxv062849@pdx.rh.CN85.dnsmgr.net> References: <201704251907.v3PJ7Mxv062849@pdx.rh.CN85.dnsmgr.net> From: Xin LI Date: Tue, 25 Apr 2017 12:29:01 -0700 Message-ID: Subject: Re: svn commit: r317409 - head/contrib/tcpdump To: rgrimes@freebsd.org Cc: Benjamin Kaduk , Gleb Smirnoff , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Apr 2017 19:29:03 -0000 On Tue, Apr 25, 2017 at 12:07 PM, Rodney W. Grimes wrote: > [ Charset UTF-8 unsupported, converting... ] >> On Tue, Apr 25, 2017 at 1:30 PM, Rodney W. Grimes < >> freebsd@pdx.rh.cn85.dnsmgr.net> wrote: >> >> > [ Charset UTF-8 unsupported, converting... ] >> > > Author: glebius >> > > Date: Tue Apr 25 15:56:46 2017 >> > > New Revision: 317409 >> > > URL: https://svnweb.freebsd.org/changeset/base/317409 >> > > >> > > Log: >> > > Cherry-pick 5d3c5151c2b885aab36627bafb8539238da27b2d, it fixes use >> > after free >> > >> > Lets not use git hashes as references in commit messages, >> > it has very little value for someone reading a log of changes >> > looking for something. There is no promise that it can be >> > found later (github can go Poof). >> > >> >> On the contrary, a git SHA1 seems like an eminently stable and unique >> search parameter! >> I agree that a commit log should inline some summary of the change as well >> as provide a >> link to the external source, but I am not worried that a future reader will >> be unable to find >> the referenced commit. > > There is no administrative policy in place that says github users shall > maintain there history. Anyone who have a copy of the git repository would be able to 'git show 5d3c5151c2b885aab36627bafb8539238da27b2d' and prove (arguably, SHA1 is now broken, but it's still better than referencing e.g. a CVS or SVN revision), and the location of the repository is publicly known. > I had too many indirections to find this change on github: > commitlog -> google -> wrong article that references this sha1 -> actual commit > > I re-iterate lets NOT start to use git hashes in our commit messages. I don't see any problem with Gleb's commit message, it have referenced the original commit using the right notion (Git SHA1) and have included a brief description of what was done at the same time.