From owner-cvs-all@FreeBSD.ORG  Tue Mar 20 02:29:49 2012
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 93932106564A;
	Tue, 20 Mar 2012 02:29:49 +0000 (UTC)
	(envelope-from wxs@atarininja.org)
Received: from syn.atarininja.org (syn.csh.rit.edu [129.21.49.45])
	by mx1.freebsd.org (Postfix) with ESMTP id 675628FC17;
	Tue, 20 Mar 2012 02:29:49 +0000 (UTC)
Received: by syn.atarininja.org (Postfix, from userid 1001)
	id C5C0D5C3A; Mon, 19 Mar 2012 22:29:42 -0400 (EDT)
Date: Mon, 19 Mar 2012 22:29:42 -0400
From: Wesley Shields <wxs@FreeBSD.org>
To: Michael Scheidell <scheidell@freebsd.org>
Message-ID: <20120320022942.GC27552@atarininja.org>
References: <201203191403.q2JE3sM8051201@repoman.freebsd.org>
	<20120319143041.GB27552@atarininja.org> <4F67438C.605@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4F67438C.605@freebsd.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/graphics/opennurbs Makefile pkg-plist
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Mar 2012 02:29:49 -0000

On Mon, Mar 19, 2012 at 10:32:44AM -0400, Michael Scheidell wrote:
> 
> 
> On 3/19/12 10:30 AM, Wesley Shields wrote:
> > Isn't it better to use ${INSTALL_DATA} here?
> >
> > -- WXS
> open a pr, let maintainer approve it.

As the person who committed this it is your responsibility to see that
issues raised are properly fixed. If you feel like the maintainer should
be brought in for such a simple change that is your decision to make,
but I shouldn't have to open a PR to address this.

> Id also like to see examples wrapper in a .if/endif and pkg-plist 
> prefixed with %%PORTEXAMPLES%%%EXAMPLES%% .

Would be nice to have also, but not my point. Using ${INSTALL_DATA} is
the right thing to do because it sets the owner and mode properly.

-- WXS