Date: Tue, 20 Nov 2012 12:17:00 +0100 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Wesley Shields <wxs@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r307565 - head/net/silc-client Message-ID: <20121120111700.GI71195@ithaqua.etoilebsd.net> In-Reply-To: <201211191622.qAJGMZps097391@svn.freebsd.org> References: <201211191622.qAJGMZps097391@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--DesjdUuHQDwS2t4N
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
I know I already told you the following, but I think it is worth saying it
loudly for other people who don't know yet about OPTIONS_DEFINE_${arch}
regards,
Bapt
On Mon, Nov 19, 2012 at 04:22:35PM +0000, Wesley Shields wrote:
> Author: wxs
> Date: Mon Nov 19 16:22:34 2012
> New Revision: 307565
> URL: http://svnweb.freebsd.org/changeset/ports/307565
>=20
=2E..
> WANT_PERL=3D yes
> =20
> -OPTIONS=3D PTHREADS "Enable pthreads support" off \
> - IPV6 "Enable IPv6 support" on \
> - ICONV "Enable international character support" on \
> - PERL "Enable perl support" on \
> - OPTIMIZED_ASM "Use assembler optimizations (i386 only)" on
> +OPTIONS_DEFINE=3D PTHREADS IPV6 ICONV PERL OPTIMIZED_ASM
> +PTHREADS_DESC=3D "Enable pthreads support"
> +OPTIMIZED_ASM_DESC=3D "Use assembler optimizations (i386 only)"
> +OPTIONS_DEFAULT=3D IPV6 ICONV PERL OPTIMIZED_ASM
OPTIONS_DEFINE=3D -PTHREADS IPV6 ICONV PERL
OPTIONS_DEFINE_i386=3D OPTIMIZED_ASM
OPTIMIZED_ASM_DESC=3D Use assembler optimizations
=2E..
> -.include <bsd.port.pre.mk>
> +.include <bsd.port.options.mk>
> =20
> .if ${ARCH} !=3D "i386"
> WITHOUT_OPTIMIZED_ASM=3D yes
> .endif
The above is uneeded as OPTIMIZED_ASM will never get defined with the _arch
syntax above.
--DesjdUuHQDwS2t4N
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)
iEYEARECAAYFAlCrZqwACgkQ8kTtMUmk6Ey/3ACeOb7t4d/ICPB+SIu191zIWWoz
X5MAoLLccTBpgYsJyBCnxO/+KMpDBp9Y
=HY+6
-----END PGP SIGNATURE-----
--DesjdUuHQDwS2t4N--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121120111700.GI71195>