From owner-freebsd-embedded@FreeBSD.ORG  Thu Aug 22 06:18:25 2013
Return-Path: <owner-freebsd-embedded@FreeBSD.ORG>
Delivered-To: freebsd-embedded@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 7210C14A;
 Thu, 22 Aug 2013 06:18:25 +0000 (UTC) (envelope-from ilya@bakulin.de)
Received: from olymp.kibab.com (olymp6.kibab.com [IPv6:2a01:4f8:160:84c1::2])
 by mx1.freebsd.org (Postfix) with ESMTP id 32EC720E8;
 Thu, 22 Aug 2013 06:18:24 +0000 (UTC)
X-DKIM: OpenDKIM Filter v2.5.2 olymp.kibab.com 931543F432
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=bakulin.de; s=default;
 t=1377152303; bh=MmwlGgFENys88KUsp0h0JcsPw8z+qlngyOZuqWtVHbc=;
 h=Date:From:To:CC:Subject:References:In-Reply-To;
 b=co8KPhTG5CebdOgTpLhMkEc2SguCp1cmZYFj6UOP8WhIXVph4QljZLC818Oh1oZYN
 JOe5+oXsBkw4mNZXIRy1vUDVLyNu7GYcDo55h/4xUhVH9UfOzJHG4eCe2MdVTqeH4N
 0SdIVVCQDEykIwc2orBiLbzKSgFHpNIuj5SZ1KYQ=
Message-ID: <5215AD32.3080800@bakulin.de>
Date: Thu, 22 Aug 2013 08:18:26 +0200
From: Ilya Bakulin <ilya@bakulin.de>
MIME-Version: 1.0
To: Adrian Chadd <adrian@freebsd.org>
Subject: Re: [PATCH] SDIO support for Globalscale Dreamplug
References: <20130702145905.GA1847@olymp.kibab.com>
 <51D3097A.8010601@FreeBSD.org> <51D3282C.1090701@bakulin.de>
 <C92CE8E1-75A0-459F-95DA-956D03DCB2E2@bsdimp.com>
 <20130703222002.GA60491@olymp.kibab.com> <51D50C55.1040300@myspectrum.nl>
 <51D531CB.3060300@bakulin.de> <51D5FE4C.9060102@bakulin.de>
 <20130821095849.GA7322@olymp.kibab.com>
 <CAJ-VmomavguSzg8z+RA81vv1KSAGrLWimQPZGZR_N9TkSymG-w@mail.gmail.com>
In-Reply-To: <CAJ-VmomavguSzg8z+RA81vv1KSAGrLWimQPZGZR_N9TkSymG-w@mail.gmail.com>
X-Enigmail-Version: 1.5.2
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Alexander Motin <mav@freebsd.org>,
 "freebsd-arm@freebsd.org" <freebsd-arm@freebsd.org>,
 "freebsd-embedded@freebsd.org" <freebsd-embedded@freebsd.org>
X-BeenThere: freebsd-embedded@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Dedicated and Embedded Systems <freebsd-embedded.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-embedded>, 
 <mailto:freebsd-embedded-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-embedded>
List-Post: <mailto:freebsd-embedded@freebsd.org>
List-Help: <mailto:freebsd-embedded-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-embedded>, 
 <mailto:freebsd-embedded-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Aug 2013 06:18:25 -0000

Hi Adrian,

On 21.08.13 23:37, Adrian Chadd wrote:
> Hi!
> 
> The marvell wifi stuff isn't ARM specific, right? So it should live in
> dev/ rather than arm/

Furthermore, it's only partly SDIO-specific. The same driver should work
for USB- and PCIe-based versions of Marvell Avastar 88W8787 and 88W8797.
The Linux driver is split into several files, by the way, for PCIe, USB
and SDIO, then for station and AP mode.

I think the best way to organize the code is to split it in layers, like
it is for ath.
I didn't know that the code is going to be universal when I started to
code the driver,
so that's why if is in sys/arm/mv.

The code in Linux driver is clean and understandable, although I would
prefer to get the documentation for the chipset and not use Linux as the
single source of information.
What's with the licensing in this case by the way?
-- 
Regards,
Ilya Bakulin