Date: Sat, 15 Jun 2013 09:20:43 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Boris Samorodov <bsam@passap.ru> Cc: svn-ports-head@freebsd.org, Baptiste Daroussin <bapt@FreeBSD.org>, svn-ports-all@freebsd.org, bapt <bapt@etoilbsd.net>, bapt <baptiste.daroussin@gmail.com>, ports-committers@freebsd.org Subject: Re: RE : Re: svn commit: r320973 - head/audio/grip Message-ID: <20130615092043.GA47945@FreeBSD.org> In-Reply-To: <51BC2E7E.8030605@passap.ru> References: <kqcoep27lv3xn9u9fa53omnt.1371285299440@email.android.com> <51BC2E7E.8030605@passap.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jun 15, 2013 at 01:06:06PM +0400, Boris Samorodov wrote: > The shlib ABI version was removed from LIB_DEPENDS and it was not > reflected at the log. So the question arises if it was intended. > Imho (yep, it's really imho) this change is serious enough to go > to the log. While I support you here on necessity of documenting every change in the commit log, dropping ABI versions from LIB_DEPENDS had been common practice for a while now, and can be forgiven. We have much worse examples of commits documented with one-liner log (which is bogus most of the times); now, *that* is a problem. :( > Second, the package definitely had changed. The dependency had > changed from libcurl.so.6 to libcurl.so. And this is recorded > at the package. I didn't know we're recording fully expanded shlibs in +CONTENTS. Library versions are recorded inside the binaries, but in this case, dropping them from LIB_DEPENDS should be no-op. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130615092043.GA47945>