From owner-freebsd-ports-bugs@freebsd.org Mon Sep 14 08:29:05 2015 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1078A9CD376 for ; Mon, 14 Sep 2015 08:29:05 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D7CAE1342 for ; Mon, 14 Sep 2015 08:29:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id t8E8T4D2045103 for ; Mon, 14 Sep 2015 08:29:04 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 203093] lang/python35: PORTVERSION causes PYTHON_REL to contain non integer values, causing make errors Date: Mon, 14 Sep 2015 08:29:04 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Ports Framework X-Bugzilla-Version: Latest X-Bugzilla-Keywords: easy, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@freebsd.org X-Bugzilla-Status: In Progress X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: koobs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Sep 2015 08:29:05 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203093 --- Comment #2 from commit-hook@freebsd.org --- A commit references this bug: Author: koobs Date: Mon Sep 14 08:28:58 UTC 2015 New revision: 396885 URL: https://svnweb.freebsd.org/changeset/ports/396885 Log: Uses/python.mk: Fix PYTHON_REL for pre-release Python versions Modify the PYTHON_REL variable assignment in python.mk so that it can support PORTVERSION's that have non-integer suffixes such as the current lang/python35 version (PORTVERSION currently 3.5.0.r3). Currently, ports that use PYTHON_REL while DEFAULT_VERSIONS is set to 3.5, fail to build with the following make error: make: "/usr/ports/Mk/Uses/python.mk" line 503: warning: String comparison operator should be either == or != make: "/usr/ports/Mk/Uses/python.mk" line 503: Malformed conditional (${PYTHON_REL} >= 3200 && defined(_PYTHON_FEATURE_PY3KPLIST)) This is caused by a non-integer value ("r3") in PYTHON_REL. While I'm here, add a comment block to be clear on what we (currently) want to achieve. PR: 203093 Reported by: Andrew Berg (aberg010 my.hennepintech.edu) Reviewed by: antoine MFH: 2015Q3 Differential Revision: https://reviews.freebsd.org/D3662 Changes: head/Mk/Uses/python.mk -- You are receiving this mail because: You are on the CC list for the bug.