From owner-svn-src-head@freebsd.org Mon Apr 25 21:46:21 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 37643B1C563 for ; Mon, 25 Apr 2016 21:46:21 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm5-vm0.bullet.mail.bf1.yahoo.com (nm5-vm0.bullet.mail.bf1.yahoo.com [98.139.213.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D5A3B1479 for ; Mon, 25 Apr 2016 21:46:20 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1461620023; bh=Eyp8boEAZftAHl+5RdvoSqkfTHm7krwp6C8fwLnSv4A=; h=Subject:To:References:Cc:From:Date:In-Reply-To:From:Subject; b=rz09Bfnvj0ngJvQXo+s/u/byGMC2Y6/PeufkF4YzlXj/z6QZ4fYdgECpwInSTgEb+M9PIWK4EwwQBehvDmtnTO8oLyEWUxMsELnq4tmGtYCBVOT5Yaxi4yjkuafQmR0Mqo2mqFWuuJUUWzt496ir+FA8ADwv441HlTr67q6jghe6KGsatzxO+UyTQj4oQNxY9bBdzcm7A/gLgN1lTJ8nLD9JaTFENULUQ/JBdGJbtqa8nAhGi5+47XM/UBzJbwOTy03YGrxwzvEgwsXAKN7v+T2vuB2TmgVHM5/7zU95Ty6SfEzD6AQc+q9ZAvthjXWfS4Sy6kbMvMuUXa5v6beudA== Received: from [66.196.81.174] by nm5.bullet.mail.bf1.yahoo.com with NNFMP; 25 Apr 2016 21:33:43 -0000 Received: from [98.139.211.162] by tm20.bullet.mail.bf1.yahoo.com with NNFMP; 25 Apr 2016 21:33:43 -0000 Received: from [127.0.0.1] by smtp219.mail.bf1.yahoo.com with NNFMP; 25 Apr 2016 21:33:43 -0000 X-Yahoo-Newman-Id: 109302.22517.bm@smtp219.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: cljyrr8VM1lbhmQgX33noSconH1Bmkz..xf5sdQ0hCz3NFS Ekji8TZnWMDEBDkuRBAOS6.hINrOI9qi5JBNiTVwD._CpWYh0qRnVxnm2mD_ BNArG_U0bt9_3DZCzEkoPciri1JoCxlezn3akr8uJUu.RN73JAiOrTYS9VC7 500mhepzkXephwAqDy1pam4vQQ6x1t.ynnqiMadntONAi2A1Zi9sFgysXyA6 nrKCssWXCWwFBX6OJhTjjp8rfYfScXCJIj1kITCKpajiy6FBebv.rUc1H0Oj 5KFof5KWouTik8O9Ta91MdHfErfzdIAo111ICRbglXhvW40QFnEfnefzG2ku faZBMeDUQj2_qkEj0u90ppJhUitl.4iL5hVqC0JL_dTFa3tL1Z5hHpbNlnSn UlO463o6zPK8t6CbVwZfjEdhXlnQ_AS3OEkRh7fC9oX9u5k5yG79w0c3b.1G DHhLpagLMhW2Bi5nz0pc6gp5VpIxu84aZtd1ycybTMqC1N8fq1aTxm_VDaz. wuTIzdTUOjQ3N7BV2KPIzFs2EhCfhxg56 X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: HEADS UP: I will revert this. (was Re: svn commit: r298443 - head/usr.bin/stat) To: Marcelo Araujo References: <201604220343.u3M3h69m058753@repo.freebsd.org> Cc: svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Pedro Giffuni Message-ID: <69810c2f-ee32-5d7b-8367-689b2afb0d97@FreeBSD.org> Date: Mon, 25 Apr 2016 16:33:55 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Apr 2016 21:46:21 -0000 Hi Marcelo; Hi; I assume you have been very busy. I will revert this in a couple of hours unless you either explain or revert it yourself. Pedro. On 04/23/16 04:23, luke wrote: > On Fri, Apr 22, 2016 at 11:43 AM, Marcelo Araujo > wrote: > > Author: araujo > Date: Fri Apr 22 03:43:06 2016 > New Revision: 298443 > URL: https://svnweb.freebsd.org/changeset/base/298443 > > Log: > Use macro MAX() from sys/param.h. > > MFC after: 2 weeks. > > Modified: > head/usr.bin/stat/stat.c > > Modified: head/usr.bin/stat/stat.c > ============================================================================== > --- head/usr.bin/stat/stat.c Fri Apr 22 03:37:27 2016 > (r298442) > +++ head/usr.bin/stat/stat.c Fri Apr 22 03:43:06 2016 > (r298443) > @@ -1025,7 +1025,7 @@ format1(const struct stat *st, > * > * Nanoseconds: long. > */ > - (void)snprintf(tmp, sizeof(tmp), "%dld", prec > 9 ? > 9 : prec); > + (void)snprintf(tmp, sizeof(tmp), "%dld", MAX(9, prec)); > (void)strcat(lfmt, tmp); > > /* > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to > "svn-src-head-unsubscribe@freebsd.org > " > > > > Hi, > > Should this be MIN() ? > > (void)snprintf(tmp, sizeof(tmp), "%dld", MIN(prec, 9)); > > > -- > Chang-Hsien Tsai >