From owner-svn-src-all@freebsd.org Sun Jun 3 21:58:57 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8DD7DFE22F2; Sun, 3 Jun 2018 21:58:57 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E84BB7F8AC; Sun, 3 Jun 2018 21:58:56 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from [10.10.154.196] (unknown [185.93.6.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 92FC843D00; Sun, 3 Jun 2018 23:58:48 +0200 (CEST) From: Dimitry Andric Message-Id: <2231964C-8130-416D-963D-77F93DF2F08A@FreeBSD.org> Content-Type: multipart/signed; boundary="Apple-Mail=_01C10913-2CF3-4271-ABB9-B9BA8952D58B"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 11.4 \(3445.8.2\)) Subject: Re: svn commit: r334586 - head/sys/fs/nfsserver Date: Sun, 3 Jun 2018 23:58:43 +0200 In-Reply-To: <201806031946.w53JkiHm084473@repo.freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org To: Rick Macklem References: <201806031946.w53JkiHm084473@repo.freebsd.org> X-Mailer: Apple Mail (2.3445.8.2) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Jun 2018 21:58:57 -0000 --Apple-Mail=_01C10913-2CF3-4271-ABB9-B9BA8952D58B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 3 Jun 2018, at 21:46, Rick Macklem wrote: >=20 > Author: rmacklem > Date: Sun Jun 3 19:46:44 2018 > New Revision: 334586 > URL: https://svnweb.freebsd.org/changeset/base/334586 >=20 > Log: > Fix a gcc8 warning about a write only variable. >=20 > gcc8 warns that "verf" was set but not used. This was because the = code > that uses it is disabled via a "#if 0". > This patch adds a "#if 0" to the variable's declaration and = assignment > to get rid of the warning. > This way the code could be re-enabled without difficulty. >=20 > Requested by: mmacy > MFC after: 2 weeks >=20 > Modified: > head/sys/fs/nfsserver/nfs_nfsdport.c >=20 > Modified: head/sys/fs/nfsserver/nfs_nfsdport.c > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/sys/fs/nfsserver/nfs_nfsdport.c Sun Jun 3 19:37:17 2018 = (r334585) > +++ head/sys/fs/nfsserver/nfs_nfsdport.c Sun Jun 3 19:46:44 2018 = (r334586) > @@ -1574,7 +1574,10 @@ nfsrvd_readdir(struct nfsrv_descript *nd, int = isdgram, > struct nfsvattr at; > int nlen, error =3D 0, getret =3D 1; > int siz, cnt, fullsiz, eofflag, ncookies; > - u_int64_t off, toff, verf; > + u_int64_t off, toff; > +#if 0 > + u_int64_t verf; > +#endif > u_long *cookies =3D NULL, *cookiep; > struct uio io; > struct iovec iv; > @@ -1591,7 +1594,9 @@ nfsrvd_readdir(struct nfsrv_descript *nd, int = isdgram, > NFSM_DISSECT(tl, u_int32_t *, 5 * NFSX_UNSIGNED); > off =3D fxdr_hyper(tl); > tl +=3D 2; > +#if 0 > verf =3D fxdr_hyper(tl); > +#endif This functionally changes the code, though. Is fxdr_hyper() no longer supposed to be called? -Dimitry --Apple-Mail=_01C10913-2CF3-4271-ABB9-B9BA8952D58B Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCWxRkkwAKCRCwXqMKLiCW o0XdAJ0fRKuGePH3FJo0SXM8teDcYIJfJgCg2DvcL3Pj3626zidWL9LHHNloH3E= =rw8x -----END PGP SIGNATURE----- --Apple-Mail=_01C10913-2CF3-4271-ABB9-B9BA8952D58B--