From owner-freebsd-hackers@FreeBSD.ORG Fri Apr 11 18:39:55 2014 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id EB08BF1A; Fri, 11 Apr 2014 18:39:54 +0000 (UTC) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 8A69C1DD3; Fri, 11 Apr 2014 18:39:54 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.8/8.14.8) with ESMTP id s3BIdnwQ028167; Fri, 11 Apr 2014 21:39:49 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.8.3 kib.kiev.ua s3BIdnwQ028167 Received: (from kostik@localhost) by tom.home (8.14.8/8.14.8/Submit) id s3BIdne2028166; Fri, 11 Apr 2014 21:39:49 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 11 Apr 2014 21:39:49 +0300 From: Konstantin Belousov To: Daniel Eischen Subject: Re: Stuck CLOSED sockets / sshd / zombies... Message-ID: <20140411183949.GX21331@kib.kiev.ua> References: <20140409111917.GH21331@kib.kiev.ua> <851413886E3982D2CCFEA9D9@Mail-PC.tdx.co.uk> <20140410184855.GP21331@kib.kiev.ua> <211BD03C086DDB1A07FDF036@Mail-PC.tdx.co.uk> <20140411131649.GR21331@kib.kiev.ua> <652B8CA4866C0B9E4650430B@Mail-PC.tdx.co.uk> <20140411141526.GT21331@kib.kiev.ua> <464979E8F6FCBD7EA7DAA38B@Mail-PC.tdx.co.uk> <20140411160628.GV21331@kib.kiev.ua> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ezezolMAAIf/M2F2" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on tom.home Cc: freebsd-hackers@freebsd.org, Karl Pielorz X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Apr 2014 18:39:55 -0000 --ezezolMAAIf/M2F2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 11, 2014 at 01:23:00PM -0400, Daniel Eischen wrote: > On Fri, 11 Apr 2014, Konstantin Belousov wrote: > > The correct solution is to merge libthr into libc. Some neccessary > > preparations were already done, but the main work did not started yet. > > This is huge efforts, and it probably should be coordinated with some > > other ABI changes planed for libthr to support process-shared locks. >=20 > Eek, no, I don't think that is necessary. When we go to using real > structs instead of pointers for synchronization types (mutex, CV) > in libthr, then I don't think there will be a problem. Could you, please, clarify what do you consider not neccessary ? The merge, the (unrelated) ABI change, or coordination ? BTW, below is the updated patch with the workaround for sshd issue. diff --git a/secure/usr.sbin/sshd/Makefile b/secure/usr.sbin/sshd/Makefile index 4f730a9..b3231a4 100644 --- a/secure/usr.sbin/sshd/Makefile +++ b/secure/usr.sbin/sshd/Makefile @@ -57,6 +57,12 @@ CFLAGS+=3D -DNONE_CIPHER_ENABLED DPADD+=3D ${LIBCRYPT} ${LIBCRYPTO} ${LIBZ} LDADD+=3D -lcrypt -lcrypto -lz =20 +# put the threading library last +.if ${MK_KERBEROS_SUPPORT} !=3D "no" +DPADD+=3D ${LIBPTHREAD} +LDADD+=3D -lpthread +.endif + .if defined(LOCALBASE) CFLAGS+=3D -DXAUTH_PATH=3D\"${LOCALBASE}/bin/xauth\" .endif --ezezolMAAIf/M2F2 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQIcBAEBAgAGBQJTSDb0AAoJEJDCuSvBvK1BZDAQAIY++mRAuxzaJPxOimZVvaeG RS7C0D59si8OsFh9PAISnM4bWPT53io0WSou9nb0u32QDL1hfCtFuTk6nlfFDdbm aY5C/LvXW93GKZBlpBnVGEkxDSNuHzOHyAzMDbxAerk57ygc6fD0dWJKHK99GIXi YL2XfooSjQ4InLDaSTmxrG9GVBZxH1bZl3w6IN4Ptsabdfl3dlfYsj0arbd36H8d xfQGjT4SmltauO4ifEcD4gQbv+owmpmdEKYk+ft6Rhk3nAFDU30TJrDltBYT3AXu xQWo7VnrLbRqAUGmjJQwPB7kHh6xHst0LNMQcN/pgYb/MVU9NDGWoUVKgmlT2b4s p+t5NS/OPhdq8qx2RRNRLLy2kG6JCYRL+z1fyQt+6Kx73GmmLGKRGqvSvAg4k30n fiTTheliXR58AFVwtGakDXORZPXGgjYP4QcWHjN7ydi1d86sjfEHmjPATp9mQz3e KLtKByNTBrJZh+bWnrMIOhZnA3O3eJub3A6rU2m3zLHSnvhm6OrtYv7/hqMsvn/d 7jLHgFsEZRPLWvaikZMcfBMkOVyjAXbTSn6HvIZ51SBMTMi/jRtkdJo37YJ49RVA OLVHQ8aFo8NgQhmStWech55c7Xj9UwpMi7fWIno5ZP0EtlQ1sI6qWKD3+/jHh15o 5RnwGk0Tttf3Lz1Wrwc0 =I1EY -----END PGP SIGNATURE----- --ezezolMAAIf/M2F2--