Date: Thu, 29 Aug 2024 11:36:25 -0300 From: Joseph Mingrone <jrm@FreeBSD.org> To: Cy Schubert <Cy.Schubert@cschubert.com> Cc: Mathieu Arnold <mat@freebsd.org>, Gleb Popov <arrowd@freebsd.org>, Cy Schubert <cy@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: ccc21de09381 - main - devel/binutils: Add devel/elfutils dependency options Message-ID: <86o75bpf9y.fsf@phe.ftfl.ca> In-Reply-To: <20240829124237.6E277483@slippy.cwsent.com> (Cy Schubert's message of "Thu, 29 Aug 2024 05:42:37 -0700") References: <202408281603.47SG35Q9035605@gitrepo.freebsd.org> <CALH631nFVYyks4DB%2BT8%2BC8r5Y6GHT4Su8mzhDaJ8BQ1=PMVZPA@mail.gmail.com> <20240828180439.22B0730E@slippy.cwsent.com> <2ypgfpzxn7m4jzzbacyvrlw7htj5iyg7zwdb7mjcbknfjr3ee4@ipqdfyay3s4m> <20240829124237.6E277483@slippy.cwsent.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-=
Content-Type: text/plain
On Thu, 2024-08-29 at 05:42, Cy Schubert <Cy.Schubert@cschubert.com> wrote:
> In message <2ypgfpzxn7m4jzzbacyvrlw7htj5iyg7zwdb7mjcbknfjr3ee4@ipqdfyay3s4m>
> , M
> athieu Arnold writes:
>> --t2cwj7kshsfy5exo
>> Content-Type: text/plain; charset=us-ascii
>> Content-Disposition: inline
>> Content-Transfer-Encoding: quoted-printable
>> On Wed, Aug 28, 2024 at 11:04:39AM GMT, Cy Schubert wrote:
>> > In message <CALH631nFVYyks4DB+T8+C8r5Y6GHT4Su8mzhDaJ8BQ1=3DPMVZPA@mail.gm=
>> ail.c
>> > om>
>> > , Gleb Popov writes:
>> > > On Wed, Aug 28, 2024 at 7:03=3DE2=3D80=3DAFPM Cy Schubert <cy@freebsd.o=
>> rg> wrote:
>> > > > +# In case devel/elfutils has been previously installed.
>> > > > +.if ${PORT_OPTIONS:MELFU_AUTO} && exists(${LOCALBASE}/lib/libdebugin=
>> fod.=3D
>> > > so)
>> > > > +LIB_DEPENDS+=3D3D libdebuginfod.so:devel/elfutils
>> > > > +.endif
>> > > Hmm, this looks strange to me. LIB_DEPENDS is used to pull in
>> > > libraries that are missing, but then the "exists" condition will
>> > > always be false.
>> >=20
>> > Correct. The condition will always be false when building with poudriere=
>> =20
>> > but for those building the port by hand, and have manually installed=20
>> > devel/elfutils prior to building and installing manually the condition wi=
>> ll=20
>> > then be true.
>> >=20
>> > Much committers' dismay some users don't use binary packages, you and I a=
>> s=20
>> > committers prefer people use binary packages. But unfortunately this is n=
>> ot=20
>> > always the case. The PR was submitted by a person who builds his ports by=
>> =20
>> > hand.
>> It would be better to disable the finding of libdebuginfod in LOCALBASE,
>> so that everyone has the same binutils, and nobody gets a possibly
>> different behavior.
> In other words, just let it auto-detect?
Hi Cy,
It looks like there is a --with-debuginfod configure option. Could we
remove the OPTIONS_RADIO and make it a single ELFU knob? Something like
below would make detection of the library and the dependency on
devel/elfutils deterministic.
ELFU_DESC= Depend on devel/elfutils
ELFU_CONFIGURE_WITH= debuginfod
ELFU_LIB_DEPENDS= libdebuginfod.so:devel/elfutils
Joe
--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQKkBAEBCgCOFiEEVbCTpybDiFVxIrrVNqQMg7DW754FAmbQh2lfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU1
QjA5M0E3MjZDMzg4NTU3MTIyQkFENTM2QTQwQzgzQjBENkVGOUUQHGpybUBmcmVl
YnNkLm9yZwAKCRA2pAyDsNbvnoSbD/4llILqs2gkrigDPVA7gl+DAtCowJTpnGLk
OpU3wstH19S4eoc4jQXrG3jWapzpG1TF/8u/dRAhBJchwEBpE+SJj/ygpQhOPw2d
J89kzJkdTl9YpWJOMeQpYPrJCOsVXokMqbvhXcAfvxEGps1ZBIBp26+4wH0pMdyU
MEw1yQUDTeAs0lFkCoQQgzo2geUXNkhwv34rii9QkVDGt4WAr1YwYGamhH3x1GaI
F4QhstJaRuKM1S49qDUKfKoW4Htmt6eNVnosC2nC1aj8Cm5ZhRrTIWab8DX1aazS
7UMDDVf/x3K3Y8rKzRdVqhROiDnMCZoanTlJYLzwqVRyw7ryZDFbsxDRApImMdrI
EVJXX4sKhkmPa/vLJo+mSNsM2W/gwer0i942tXZ5p1guxOgVtI3zYoX5OX5Ba74j
E2idvxfEfRY1RgPEe5WLtaMXsbXcmank1pK79xvyi3ayqoWJ3gTeEO/UkUYqtQL+
jW53WJxZ+fsMoRBXYAURrSFhj+fif6/JW29JLU9Fav7c4RQltE2rl8tdjliW4vYe
Das7qPQf81hDcpy0bVnhV9hhnsbRB72+ulke8sR4OnIPcYTqwtdl4ITdzy4IM7Wg
pZY8T7AXS4hGiva5JrIWVD6+A03MSfQjleXbO6pjXP0OBRRn/OnDWRgEEd9ZfUQO
tu/Y2FAAZw==
=lANH
-----END PGP SIGNATURE-----
--=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86o75bpf9y.fsf>