From owner-p4-projects@FreeBSD.ORG Sun Nov 9 09:16:30 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 6A365106567D; Sun, 9 Nov 2008 09:16:30 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2E3281065673 for ; Sun, 9 Nov 2008 09:16:30 +0000 (UTC) (envelope-from hselasky@freebsd.org) Received: from swip.net (mailfe05.swip.net [212.247.154.129]) by mx1.freebsd.org (Postfix) with ESMTP id 8B7F58FC1D for ; Sun, 9 Nov 2008 09:16:29 +0000 (UTC) (envelope-from hselasky@freebsd.org) X-Cloudmark-Score: 0.000000 [] X-Cloudmark-Analysis: v=1.0 c=1 a=byfPAnWZzwkA:10 a=d6BVkb5LuPPVEe4iNQMLyA==:17 a=6I5d2MoRAAAA:8 a=F7A8L05IgF4PQvV9iJgA:9 a=_cCp1yQ5YFvldygsPWMA:7 a=qMGSUFkDLLeeLULzIkjJLwWOYKIA:4 a=SV7veod9ZcQA:10 a=LY0hPdMaydYA:10 Received: from [62.113.135.6] (account mc467741@c2i.net [62.113.135.6] verified) by mailfe05.swip.net (CommuniGate Pro SMTP 5.2.6) with ESMTPA id 1043595833; Sun, 09 Nov 2008 10:16:27 +0100 From: Hans Petter Selasky To: "M. Warner Losh" Date: Sun, 9 Nov 2008 10:18:38 +0100 User-Agent: KMail/1.9.7 References: <200811041851.mA4Ip2cP040847@repoman.freebsd.org> <20081109.001527.1720213087.imp@bsdimp.com> In-Reply-To: <20081109.001527.1720213087.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200811091018.38787.hselasky@freebsd.org> Cc: perforce@freebsd.org Subject: Re: PERFORCE change 152478 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Nov 2008 09:16:30 -0000 On Sunday 09 November 2008, M. Warner Losh wrote: > In message: <200811041851.mA4Ip2cP040847@repoman.freebsd.org> > > Hans Petter Selasky writes: > : http://perforce.freebsd.org/chv.cgi?CH=152478 > : > : Change 152478 by hselasky@hselasky_laptop001 on 2008/11/04 18:50:56 > : > : > : Patch to support a common "usbdevs" file. > : > : Affected files ... > : > : .. //depot/projects/usb/src/sys/dev/usb/usbdevs#25 edit > : .. //depot/projects/usb/src/sys/dev/usb2/core/usbdevs#11 delete > : .. //depot/projects/usb/src/sys/dev/usb2/include/Makefile#4 edit > : .. //depot/projects/usb/src/sys/dev/usb2/include/usb2_devid.h#10 edit > : .. //depot/projects/usb/src/sys/dev/usb2/include/usb2_devtable.h#10 edit > : > : Differences ... > : > : ==== //depot/projects/usb/src/sys/dev/usb/usbdevs#25 (text+ko) ==== > : > : @@ -795,7 +795,7 @@ > : > : /* AIPTEK products */ > : product AIPTEK POCKETCAM3M 0x2011 PocketCAM 3Mega > : -product AIPTEK2 PENCAM_MEGA_1_3 0x504a PenCam Mega 1.3 > : +product SUNPLUS PENCAM_MEGA_1_3 0x504a PenCam Mega 1.3 > > This should have its own section. > > : /* AirPrime products */ > : product AIRPRIME PC5220 0x0112 CDMA Wireless PC Card > : @@ -1006,7 +1006,7 @@ > : > : /* Chicony products */ > : product CHICONY KB8933 0x0001 KB-8933 keyboard > : -product CHICONY2 TWINKLECAM 0x600d TwinkleCam USB camera > : +product MICRODIA TWINKLECAM 0x600d TwinkleCam USB camera > > Ditot. > > : /* CH Products */ > : product CHPRODUCTS PROTHROTTLE 0x00f1 Pro Throttle > > Warner Hi, The problem is that the usbdevs does not succeed generating the verbose debug table because the AIPTEK2 and CHICONY2 vendor ID's do not exist. By looking at the source of these ID's I figured out the correct vendor ID. Is it possible you could fix this in -current Warner ? --HPS