From owner-freebsd-ports@FreeBSD.ORG Wed Jul 23 11:54:28 2008 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 861751065679 for ; Wed, 23 Jul 2008 11:54:28 +0000 (UTC) (envelope-from osvaldsson@icelandic.net) Received: from ik-out-1112.google.com (ik-out-1112.google.com [66.249.90.179]) by mx1.freebsd.org (Postfix) with ESMTP id 2C8398FC08 for ; Wed, 23 Jul 2008 11:54:27 +0000 (UTC) (envelope-from osvaldsson@icelandic.net) Received: by ik-out-1112.google.com with SMTP id c30so2226540ika.3 for ; Wed, 23 Jul 2008 04:54:26 -0700 (PDT) Received: by 10.210.26.10 with SMTP id 10mr5893230ebz.15.1216812610839; Wed, 23 Jul 2008 04:30:10 -0700 (PDT) Received: from ?192.168.254.101? ( [81.15.120.54]) by mx.google.com with ESMTPS id u14sm7807669gvf.6.2008.07.23.04.30.08 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 23 Jul 2008 04:30:09 -0700 (PDT) Message-Id: From: Olafur Osvaldsson To: "Florent Thoumie" In-Reply-To: Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v928.1) Date: Wed, 23 Jul 2008 11:30:06 +0000 References: <1592773212-1216766394-cardhu_decombobulator_blackberry.rim.net-2001801074-@bxe056.bisx.produk.on.blackberry> X-Mailer: Apple Mail (2.928.1) Cc: ports@freebsd.org, pgollucci@freebsd.org, araujo@freebsd.org Subject: Re: ports/125625: [PATCH] dns/nsd: USE_RC_SUBR != yes X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2008 11:54:28 -0000 This is something the PR responsible introduced in his original patch... On 23.7.2008, at 10:14, Florent Thoumie wrote: > On Tue, Jul 22, 2008 at 11:41 PM, Olafur Osvaldsson > wrote: >> Why has committing a patch gotten so complicated? > > One day since the last update to the PR... The PR responsible recently > got repository privileges so he's probably getting familiar to the > procedures. > > While I'm looking at it, you're checking if NO_INSTALL_MANPAGES which > is wrong. This variable is meant to be set by ports, not users. Even > if it were, you would end up with a incomplete packing list, because > your port installs manual pages unconditionally. I'd suggest getting > rid of the check completely. > > -- > Florent Thoumie > flz@FreeBSD.org > FreeBSD Committer