From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Jun 2 15:08:38 2006 Return-Path: X-Original-To: freebsd-ports-bugs@FreeBSD.org Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EE2C516A44E for ; Fri, 2 Jun 2006 15:08:38 +0000 (UTC) (envelope-from ino-qc@spotteswoode.de.eu.org) Received: from mail-out01.broadnet-mediascape.de (mail-out01.broadnet-mediascape.de [62.206.1.18]) by mx1.FreeBSD.org (Postfix) with SMTP id DDD5343D53 for ; Fri, 2 Jun 2006 15:08:37 +0000 (GMT) (envelope-from ino-qc@spotteswoode.de.eu.org) Received: (qmail 20583 invoked by uid 113); 2 Jun 2006 15:08:35 -0000 Received: from 212.99.206.141 by mail-out01 (envelope-from , uid 106) with qmail-scanner-1.25 (trophie: 7.510-1002/475/114777. Clear:RC:1(212.99.206.141):. Processed in 0.469385 secs); 02 Jun 2006 15:08:35 -0000 X-Qmail-Scanner-Mail-From: ino-qc@spotteswoode.de.eu.org via mail-out01 X-Qmail-Scanner: 1.25 (Clear:RC:1(212.99.206.141):. Processed in 0.469385 secs) Received: from d463ce8d.datahighways.de (HELO spotteswoode.dnsalias.org) (212.99.206.141) by mail-out01.broadnet-mediascape.de with SMTP; 2 Jun 2006 15:08:34 -0000 Received: by spotteswoode.dnsalias.org (Postfix, from userid 0) id EC55215AA5; Fri, 2 Jun 2006 17:08:33 +0200 (CEST) Date: Fri, 2 Jun 2006 17:08:33 +0200 From: clemens fischer To: Brad Huntting Message-ID: <20060602150833.GB617@spotteswoode.de.eu.org> Mail-Followup-To: Brad Huntting , Ion-Mihai IOnut Tetcu , freebsd-ports-bugs@FreeBSD.org References: <20060516140228.GA607@spotteswoode.de.eu.org> <200605161527.k4GFR5PT001207@hunkular.glarp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200605161527.k4GFR5PT001207@hunkular.glarp.com> X-PGP-ID: 0x214190AF Cc: freebsd-ports-bugs@FreeBSD.org, Ion-Mihai IOnut Tetcu Subject: Re: ports/96918: sysutils/fcron: fcrondyn completely broken X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jun 2006 15:08:44 -0000 > Brad Huntting: > The generic fix is to add code to configure.in and config.h.in.in to > set HAVE_SA_LEN. Then, when filling in the struct sockaddr before a > connect or bind, use #ifdef HAVE_SA_LEN and fill in the sun_len field. > This is the bulk of the patch in PR ports/97066. Note, in this case, > the code leading up to connect() was did not correctly check the path > length and called strncpy() with incorrect arguments, so I had to fix > that too. it has been some time since you fixed the port, could you also commit it, please? > But, yes, the changes to configure.in and config.in.in are generic > enough they should be useable with anything that uses gnu configure > just place the added lines in the right place. Then add the > appropreate #ifdefs when setting up the socket address before bind and > connect. Such a patch should be ecumenical enough that it can be sent > to the original code maintainer. After all, FreeBSD is not the only > system to use sa_len. i'll send this over to thibault Godouet, the original author of fcron. clemens