From owner-freebsd-bugs@FreeBSD.ORG Sun Sep 12 17:40:25 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7B04E16A4CE for ; Sun, 12 Sep 2004 17:40:25 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4C00843D54 for ; Sun, 12 Sep 2004 17:40:25 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i8CHeNli009006 for ; Sun, 12 Sep 2004 17:40:23 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i8CHeNir009005; Sun, 12 Sep 2004 17:40:23 GMT (envelope-from gnats) Resent-Date: Sun, 12 Sep 2004 17:40:23 GMT Resent-Message-Id: <200409121740.i8CHeNir009005@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dan Lukes Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6BDDF16A4CE for ; Sun, 12 Sep 2004 17:34:41 +0000 (GMT) Received: from kulesh.obluda.cz (kulesh.obluda.cz [193.179.22.243]) by mx1.FreeBSD.org (Postfix) with ESMTP id D1A8B43D55 for ; Sun, 12 Sep 2004 17:34:39 +0000 (GMT) (envelope-from dan@obluda.cz) Received: from kulesh.obluda.cz (localhost.eunet.cz [127.0.0.1]) by kulesh.obluda.cz (8.13.1/8.13.1) with ESMTP id i8CHYRrK010897 for ; Sun, 12 Sep 2004 19:34:28 +0200 (CEST) (envelope-from dan@obluda.cz) Received: (from root@localhost) by kulesh.obluda.cz (8.13.1/8.13.1/Submit) id i8CHYQK1010896 for FreeBSD-gnats-submit@freebsd.org; Sun, 12 Sep 2004 19:34:26 +0200 (CEST) (envelope-from dan@obluda.cz) Message-Id: <200409121734.i8CHYQK1010896@kulesh.obluda.cz> Date: Sun, 12 Sep 2004 19:34:26 +0200 (CEST) From: Dan Lukes To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: bin/71659: [PATCH] cleanup of the usr.sbin/mount_portalfs code X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Dan Lukes List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Sep 2004 17:40:25 -0000 >Number: 71659 >Category: bin >Synopsis: [PATCH] cleanup of the usr.sbin/mount_portalfs code >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Sep 12 17:40:23 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Dan Lukes >Release: FreeBSD 5.3-BETA3 i386 >Organization: Obludarium >Environment: System: FreeBSD kulesh.obluda.cz 5.3-BETA3 FreeBSD 5.3-BETA3 #8: Sun Sep 5 07:06:40 CEST 2004 dan@kulesh.obluda.cz:/usr/obj/usr/src/sys/Dan i386 usr.sbin/mount_portalfs/pt_tcplisten.c,v 1.4 2004/08/07 04:27:50 imp >Description: There are more than 5000 warnings issued during "make buildworld". Some of them are false positives, but some of them are sign of true errors. Nobody is upset by warnings due it's amount, so some errors remain uncorrected. I want to cleanup the code-base from warnings, so warnings will become "attention mark" again. usr.sbin/mount_portalfs/pt_tcplisten.c:83: warning: 'ipp' might be used uninitialized in this function >How-To-Repeat: N/A >Fix: *** usr.sbin/mount_portalfs/pt_tcplisten.c.ORIG Sun Aug 8 21:13:25 2004 --- usr.sbin/mount_portalfs/pt_tcplisten.c Sun Sep 12 04:49:09 2004 *************** *** 80,86 **** char *q; struct hostent *hp; struct servent *sp; ! struct in_addr **ipp; struct in_addr *ip[2]; struct in_addr ina; u_short s_port; --- 80,86 ---- char *q; struct hostent *hp; struct servent *sp; ! struct in_addr **ipp = ipp; /* "init" to avoid "might be used uninitialised" warning */ struct in_addr *ip[2]; struct in_addr ina; u_short s_port; >Release-Note: >Audit-Trail: >Unformatted: