From owner-p4-projects@FreeBSD.ORG  Tue May  3 15:49:15 2005
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 313B016A4CF; Tue,  3 May 2005 15:49:15 +0000 (GMT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E312316A4CE
	for <perforce@freebsd.org>; Tue,  3 May 2005 15:49:14 +0000 (GMT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9FF6343D66
	for <perforce@freebsd.org>; Tue,  3 May 2005 15:49:14 +0000 (GMT)
	(envelope-from csjp@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j43Fn9wY051169
	for <perforce@freebsd.org>; Tue, 3 May 2005 15:49:09 GMT
	(envelope-from csjp@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j43Fn9Os051166
	for perforce@freebsd.org; Tue, 3 May 2005 15:49:09 GMT
	(envelope-from csjp@freebsd.org)
Date: Tue, 3 May 2005 15:49:09 GMT
Message-Id: <200505031549.j43Fn9Os051166@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	csjp@freebsd.org using -f
From: "Christian S.J. Peron" <csjp@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 76434 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 May 2005 15:49:16 -0000

http://perforce.freebsd.org/chv.cgi?CH=76434

Change 76434 by csjp@csjp_xor on 2005/05/03 15:48:40

	zero out checksum structure before writing it out to the extended attr.

Affected files ...

.. //depot/projects/trustedbsd/mac/sys/security/mac_chkexec/mac_chkexec.c#2 edit

Differences ...

==== //depot/projects/trustedbsd/mac/sys/security/mac_chkexec/mac_chkexec.c#2 (text+ko) ====

@@ -609,6 +609,7 @@
 		error = ha->crypto_hash(vp, cred, digest);
 		if (error)
 			return (error);
+		bzero(&vcsum, sizeof(vcsum));
 		memcpy(vcsum.vs_sum, digest, ha->hashsize);
 		vcsum.vs_flags = ha->hashmask;
 		error = mac_chkexec_set_vcsum(vp, &vcsum);
@@ -630,6 +631,7 @@
 	match = (memcmp(digest, vcsum.vs_sum,
 	    ha->hashsize) == 0);
 	if (!match && !mac_chkexec_enforce) {
+		bzero(&vcsum, sizeof(vcsum));
 		memcpy(vcsum.vs_sum, digest, ha->hashsize);
 		vcsum.vs_flags = ha->hashmask;
 		error = mac_chkexec_set_vcsum(vp, &vcsum);
@@ -843,6 +845,7 @@
 		vput(nd.ni_vp);
 		return (error);
 	}
+	bzero(&vcsum, sizeof(vcsum));
 	memcpy(vcsum.vs_sum, digest, ha->hashsize);
 	vcsum.vs_flags = ha->hashmask;
 	error = mac_chkexec_set_vcsum(nd.ni_vp, &vcsum);