From owner-cvs-all@FreeBSD.ORG  Mon Apr 25 09:02:15 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id C46AD16A4CF; Mon, 25 Apr 2005 09:02:15 +0000 (GMT)
Received: from arabica.esil.univ-mrs.fr (arabica.esil.univ-mrs.fr
	[139.124.41.108])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id E32B243D5C; Mon, 25 Apr 2005 09:02:09 +0000 (GMT)
	(envelope-from herve.quiroz@esil.univ-mrs.fr)
Received: from arabica.esil.univ-mrs.fr (localhost [127.0.0.1])
	j3P926cC082866;	Mon, 25 Apr 2005 11:02:06 +0200 (CEST)
	(envelope-from herve.quiroz@esil.univ-mrs.fr)
Received: (from rv@localhost)
	by arabica.esil.univ-mrs.fr (8.13.3/8.13.3/Submit) id j3P926q1082865;
	Mon, 25 Apr 2005 11:02:06 +0200 (CEST)
	(envelope-from herve.quiroz@esil.univ-mrs.fr)
X-Authentication-Warning: arabica.esil.univ-mrs.fr: rv set sender to
	herve.quiroz@esil.univ-mrs.fr using -f
Date: Mon, 25 Apr 2005 11:02:06 +0200
From: Herve Quiroz <herve.quiroz@esil.univ-mrs.fr>
To: Sam Lawrance <lawrance@FreeBSD.org>
Message-ID: <20050425090206.GA82306@arabica.esil.univ-mrs.fr>
References: <200504250347.j3P3lopR048231@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200504250347.j3P3lopR048231@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.1i
cc: cvs-ports@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/math/vtk-java Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Apr 2005 09:02:16 -0000

On Mon, Apr 25, 2005 at 03:47:50AM +0000, Sam Lawrance wrote:
> lawrance    2005-04-25 03:47:50 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     math/vtk-java        Makefile 
>   Log:
>   Fix plist error - only create example directories when WITH_TESTING is set.
>   
>   Reported by:    pointykris
>   Approved by:    clement (mentor, implicit)
>   
>   Revision  Changes    Path
>   1.6       +1 -1      ports/math/vtk-java/Makefile

I missed the previous commit in which you updated the port to
bsd.java.mk 2.0. There is a small issue with the update:

  JAVA_BUILD=	jdk

This statement is useless, as the default behaviour, when nothing is
specified (neither JAVA_BUILD, JAVA_RUN, nor JAVA_EXTRACT) is the
following:

  JAVA_BUILD=	jdk
  JAVA_RUN=	jre

Moreover, if you do specify JAVA_BUILD but not JAVA_RUN, the port will
not register any run dependency on the selected JDK:

$ cd /usr/ports/math/vtk-java
$ make run-depends-list
/usr/ports/graphics/jpeg
/usr/ports/graphics/png
/usr/ports/graphics/tiff
/usr/ports/math/vtk
/usr/ports/textproc/expat2
/usr/ports/x11/xorg-libraries

--> no JDK

I would have fixed it myself, but I took the opportunity to inform
commiters on the topic. Plus, you probably want to discuss this with the
maintainer, in case a JDK is actually not required to run the port
(which I doubt anyway).

Herve