From owner-freebsd-current@FreeBSD.ORG Mon Nov 16 17:55:24 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 93E1F1065695 for ; Mon, 16 Nov 2009 17:55:24 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from mail-yx0-f171.google.com (mail-yx0-f171.google.com [209.85.210.171]) by mx1.freebsd.org (Postfix) with ESMTP id 47AC88FC1F for ; Mon, 16 Nov 2009 17:55:24 +0000 (UTC) Received: by yxe1 with SMTP id 1so937014yxe.3 for ; Mon, 16 Nov 2009 09:55:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:from:date:to:cc :subject:message-id:reply-to:references:mime-version:content-type :content-disposition:in-reply-to:user-agent; bh=6S5o1NPirsWz4eG9U4buK8juiyk+EAX52/Co3mFBo9o=; b=ZlJ/gUpEpYjvr2tRKrx3fyVaap7Z7zqlgUNV6q9+5ngLCMhjAbhcrb2oVCSK6BzIop DEjnafHOwGEcJqZTF+WbybGfezCIyhTzJfrn1FUeXoiT4YPB9OdFG/Yew8blMt3asF93 Ry85y6CANo+lJ733PHRtH/KomHv8zrX+e5RXk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:date:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=EdRv7F87ZSlXCF8AWX75Gs6wBru/XEbv5t4F4pEzD0V9iHWmOPjZgpfNNr6VzeKoa2 7UTzVF9scKlRzQFUZmsi6luf2+1yfAl1axb1B8MHaZ6FyrAEYBWdyHvWKJf3NOrQKdvh 6gG0zHkyXv91bD7t0K7PYDmoWSwFoVgAI0RRA= Received: by 10.101.197.40 with SMTP id z40mr2834841anp.68.1258394123565; Mon, 16 Nov 2009 09:55:23 -0800 (PST) Received: from pyunyh@gmail.com ([174.35.1.224]) by mx.google.com with ESMTPS id 7sm963966ywf.55.2009.11.16.09.55.21 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 16 Nov 2009 09:55:22 -0800 (PST) Received: by pyunyh@gmail.com (sSMTP sendmail emulation); Mon, 16 Nov 2009 09:54:50 -0800 From: Pyun YongHyeon Date: Mon, 16 Nov 2009 09:54:50 -0800 To: Gonzalo Nemmi Message-ID: <20091116175450.GB1262@michelle.cdnetworks.com> References: <20091111223751.GE15449@michelle.cdnetworks.com> <200911122039.31431.gnemmi@gmail.com> <20091116015816.GB1124@michelle.cdnetworks.com> <200911161534.34028.gnemmi@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200911161534.34028.gnemmi@gmail.com> User-Agent: Mutt/1.4.2.3i Cc: freebsd-current@freebsd.org Subject: Re: Call for bge(4) testers X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Nov 2009 17:55:24 -0000 On Mon, Nov 16, 2009 at 03:34:33PM -0200, Gonzalo Nemmi wrote: > On Sunday 15 November 2009 11:58:16 pm Pyun YongHyeon wrote: > > On Thu, Nov 12, 2009 at 08:39:31PM -0200, Gonzalo Nemmi wrote: > > > On Thursday 12 November 2009 8:05:50 pm Pyun YongHyeon wrote: > > > > On Thu, Nov 12, 2009 at 07:12:44PM -0200, Gonzalo Nemmi wrote: > > > > > On Thursday 12 November 2009 1:47:49 am Pyun YongHyeon wrote: > > > > > > On Wed, Nov 11, 2009 at 02:37:51PM -0800, Pyun YongHyeon > wrote: > > > > > > > Hi, > > > > > > > > > > > > > > I had been working on fixing bus_dma(9) bugs and adding TSO > > > > > > > capability to bge(4). Now TSO is supported for BCM5755 or > > > > > > > newer controllers. Actually some pre-BCM5755 controllers > > > > > > > also support TSO with the help of special firmware but the > > > > > > > license issue and lower performance of firmware based TSO > > > > > > > as well as TSO bug I intentionally excluded TSO support for > > > > > > > pre-BCM5755 controllers. You can get the patch form the > > > > > > > following URL. The diff was generated against latest HEAD. > > > > > > > > > > > > > > http://people.freebsd.org/~yongari/bge/bge.tso.1111.diff > > > > > > > > > > > > Eh, there was a typo so I regenerated the diff. > > > > > > http://people.freebsd.org/~yongari/bge/bge.tso.1111-1.diff > > > > > > > > > > Hi > > > > > Just wanted to know before getting on to it, will your patch > > > > > help to resolve kern/136876? > > > > > > > > My diff includes a fix for assuming PCIe device control register > > > > and MSI control registers would be reside in fixed address. And > > > > from the pciconf output I see the your MSI control register is > > > > located at different address. However bge(4) does not touch that > > > > register for BCM5906 so I guess my diff may not fix the resume > > > > issue. > > > > > > Thanks a lot for your prompt, clear and straight answer. > > > > Would you try attached patch for BCM5906 resume issue? Not sure > > whether it help or not though. > > Hi Pyun! > Sorry for the delay, I was out of town and just got back. > I'm downloading RC3 as of now. Then I will install: > edit make.conf > edit src.conf > buildworld > buildkernel > installkernel > reboot > > mergemaster -p > make installworld > reboot > > cp bge.diff bge.patch > cd /usr/src/sys/dev/bge && patch < /path/to/patch > make > make install clean > kldunload if_bge Not sure you removed bge in GENERIC kernel configuration file. > kldload if_bge > pciconf -lcvb > ifconfig bge0 up > acpiconf -s3 > > ... and hpefully .. resume from S3 .. > > Is that ok with you or would you like me to do it in another way? That's ok. At first I wanted to add WOL to wake up bge(4) with magic packet but bge(4) seems to require a lot of workaround for each controller and it's too complex to implement at this time. Just want to know whether bge(4) can resume from suspend. > try some more stuff? > Some test in particular? > > Best Regards and thanks for the patch > Gonzalo Nemmi