From nobody Wed Apr 5 15:48:03 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Ps8Kc5NkTz43g31; Wed, 5 Apr 2023 15:52:52 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ps8Kc2Tn5z3wRM; Wed, 5 Apr 2023 15:52:52 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-lf1-f48.google.com with SMTP id br6so47227060lfb.11; Wed, 05 Apr 2023 08:52:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680709970; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=waN7xagACl7ezOKweurgPYimCNeCyuo7nGZi7Big+yA=; b=faQWd9PSdMdwaG9kdjgM00P/wBsBMINtdKbPmJliadsIasXCuHyV9f4X4TVb/iUudN qWABuFAXYve4iXPTPEtJqfL263NErp1wNb7lz2gQPAqzRz5fPaVur7rmXMxf7UKHWR+3 EjJ6SV6hrs2ztpE1y87QPe1mrWvJFYNLMNv39hXUbP3Uw32zua3PMxcipTAJ7SQqcJl6 sgBHQ0Q3QW6dZ6llX7LtvxVz+0duEG3nOZc/lXIhZs4iIsoUqeM0gslFnfUpuIvV4wBi 2GsQkReLzBLBbEbaHh3/qddanbxkKH5TFq77cpGsw1VRz5ZM5wCf+iuNG/E0W7CnBREr Ia5g== X-Gm-Message-State: AAQBX9eBkphpaoVmW6sWTZP7NkjrMaG/KvsLaUA0QLRCGMnbbxEqsKSo uIipG0pThs7ebgTdpUgdaPkACAG2S/BEBg== X-Google-Smtp-Source: AKy350axCeT3cx6ZrIsZZpEdiZJBiBZNwdk/ahPkYALlp/uad1Tm0+nXTa7R6yYL471bGpTOhqv5FQ== X-Received: by 2002:a05:6512:390e:b0:4eb:3b4c:50ac with SMTP id a14-20020a056512390e00b004eb3b4c50acmr1764914lfu.65.1680709969659; Wed, 05 Apr 2023 08:52:49 -0700 (PDT) Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com. [209.85.208.181]) by smtp.gmail.com with ESMTPSA id t11-20020a19ad0b000000b004eb3b84d2a1sm2070150lfc.114.2023.04.05.08.52.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Apr 2023 08:52:49 -0700 (PDT) Received: by mail-lj1-f181.google.com with SMTP id x20so37740057ljq.9; Wed, 05 Apr 2023 08:52:48 -0700 (PDT) X-Received: by 2002:a2e:9b50:0:b0:299:9de5:2f0c with SMTP id o16-20020a2e9b50000000b002999de52f0cmr2339942ljj.6.1680709968326; Wed, 05 Apr 2023 08:52:48 -0700 (PDT) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 References: <202304050543.3355hcZX012345@gitrepo.freebsd.org> In-Reply-To: From: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= Date: Wed, 5 Apr 2023 17:48:03 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: e933541b2131 - main - devel/samurai: Fix if LOCALBASE is not /usr/local To: Alexey Dokuchaev Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000a1f7a105f898c8ff" X-Rspamd-Queue-Id: 4Ps8Kc2Tn5z3wRM X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N --000000000000a1f7a105f898c8ff Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Apr 5, 2023 at 9:58=E2=80=AFAM Alexey Dokuchaev = wrote: > On Wed, Apr 05, 2023 at 05:43:38AM +0000, Fernando Apestegu??a wrote: > > commit e933541b2131d644ce243630544bcf210fb4be84 > > > > devel/samurai: Fix if LOCALBASE is not /usr/local > > > > PR: 270590 > > Reported by: eric@camachat.org > > ... > > PORTNAME=3D samurai > > DISTVERSION=3D 1.2-16 > > +PORTREVISION=3D 1 > > Needless bump for build-time change? > > > -@@ -3,7 +3,7 @@ > > - PREFIX=3D/usr/local > > +@@ -1,10 +1,10 @@ > > + .POSIX: > > + .PHONY: all install clean > > + > > +-PREFIX=3D/usr/local > > ++PREFIX=3D${LOCALBASE} > > This doesn't look right, PREFIX is semantically different from LOCALBASE > even > though they typically point to the same path (PREFIX is where your > generated > stuff goes, LOCALBASE is where you get precursors). If this program abus= es > the PREFIX variable and it is actually meant to be LOCALBASE, it's better > to > fix the Makefile or at least accompany such change with due comment. > > Should be correct now. Thanks! > ./danfe > --000000000000a1f7a105f898c8ff Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Wed, Apr 5, 2023 at 9:58=E2=80=AFA= M Alexey Dokuchaev <danfe@freebsd.o= rg> wrote:
eric@camachat.org
> ...
>=C2=A0 PORTNAME=3D=C2=A0 =C2=A0 samurai
>=C2=A0 DISTVERSION=3D 1.2-16
> +PORTREVISION=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 1

Needless bump for build-time change?

> -@@ -3,7 +3,7 @@
> - PREFIX=3D/usr/local
> +@@ -1,10 +1,10 @@
> + .POSIX:
> + .PHONY: all install clean
> +
> +-PREFIX=3D/usr/local
> ++PREFIX=3D${LOCALBASE}

This doesn't look right, PREFIX is semantically different from LOCALBAS= E even
though they typically point to the same path (PREFIX is where your generate= d
stuff goes, LOCALBASE is where you get precursors).=C2=A0 If this program a= buses
the PREFIX variable and it is actually meant to be LOCALBASE, it's bett= er to
fix the Makefile or at least accompany such change with due comment.


Should be correct now.

<= /div>
Thanks!
=C2=A0
./danfe
--000000000000a1f7a105f898c8ff--