Date: Sat, 17 Jun 2017 15:53:20 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Gerald Pfeifer <gerald@pfeifer.com> Cc: Alexey Dokuchaev <danfe@FreeBSD.org>, Adam Weinberger <adamw@adamw.org>, "Sergey A. Osokin" <osa@FreeBSD.org>, Bartek Rutkowski <robak@FreeBSD.org>, Adam Weinberger <adamw@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r442588 - in head/www: nginx nginx-full Message-ID: <26120b59-35f5-000f-0ddf-8cc51d6e56ac@FreeBSD.org> In-Reply-To: <alpine.LSU.2.21.1706180035110.2749@anthias.pfeifer.com> References: <201706042038.v54KcQMf001482@repo.freebsd.org> <20170605001807.GA55217@FreeBSD.org> <C38A2113-0736-4687-91D8-D49722D61E35@adamw.org> <20170606093911.GA98412@FreeBSD.org> <0130a05b-8f04-1008-16bf-d7f047823cae@FreeBSD.org> <alpine.LSU.2.21.1706180035110.2749@anthias.pfeifer.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --C4lfdX7h60qaSrveoikmnnR700mWlehlb Content-Type: multipart/mixed; boundary="Nt8mBOXhPThL1naFnTgVe6dIukSoNF9OQ"; protected-headers="v1" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Gerald Pfeifer <gerald@pfeifer.com> Cc: Alexey Dokuchaev <danfe@FreeBSD.org>, Adam Weinberger <adamw@adamw.org>, "Sergey A. Osokin" <osa@FreeBSD.org>, Bartek Rutkowski <robak@FreeBSD.org>, Adam Weinberger <adamw@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Message-ID: <26120b59-35f5-000f-0ddf-8cc51d6e56ac@FreeBSD.org> Subject: Re: svn commit: r442588 - in head/www: nginx nginx-full References: <201706042038.v54KcQMf001482@repo.freebsd.org> <20170605001807.GA55217@FreeBSD.org> <C38A2113-0736-4687-91D8-D49722D61E35@adamw.org> <20170606093911.GA98412@FreeBSD.org> <0130a05b-8f04-1008-16bf-d7f047823cae@FreeBSD.org> <alpine.LSU.2.21.1706180035110.2749@anthias.pfeifer.com> In-Reply-To: <alpine.LSU.2.21.1706180035110.2749@anthias.pfeifer.com> --Nt8mBOXhPThL1naFnTgVe6dIukSoNF9OQ Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 6/17/2017 3:44 PM, Gerald Pfeifer wrote: > On Thu, 8 Jun 2017, Bryan Drewery wrote: >> On 6/6/17 5:39 AM, Alexey Dokuchaev wrote: >>> It seems that everyone bumps port revisions whenever they please=20 >>> these days; >=20 > I can confirm I am neither doing nor omitting PORTREVISION bumps=20 > lightheartedly, Alexey. :-} >=20 >>> Just an exampler: r442562, where it was bumped for pkg-descr change=20 >>> (sic!) in a port that takes considerable time to build. :-( >> pkg-descr is part of the generated package. Bumping PORTREVISION in th= at >> commit had a real impact and change. Plus the actual content change i= s >> not a small spelling change. >=20 > Thanks, Bryan! >=20 >> It's explaining something to users about the proper use of the port an= d >> how to obtain the right package for the right environment. >> >> Yes it hurts to rebuild a port for something like this, but it is >> absolutely correct. >=20 > I find bumping (or not) PORTREVISION actually a bit tricky. >=20 > While I believe the case above is one where this is the right thing, > I have been skipping it for other cases where technically a bump would = > be required. =20 >=20 > Consider revision 443791: >=20 > Index: gcc5/pkg-descr > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > -WWW: http://gcc.gnu.org/ > +WWW: https://gcc.gnu.org >=20 > Since both the old and new URLs work just perfectly fine, and the > former only redirects to the latter, and given that lang/gcc* are > somewhat heavier ports, in this case I opted not to do the bump. Right good judgement should be used of course. It's just not black-and-white. >=20 > Strictly speaking, however, it still would be applicable and when > I don't do it always kind of wait for someone to complain. Of course, > when I then do bump in a stronger case, someone complains, too. I=20 > guess you cannot win (until we have stronger tooling as Bryan hinted > at). ;-) >=20 > Gerald >=20 --=20 Regards, Bryan Drewery --Nt8mBOXhPThL1naFnTgVe6dIukSoNF9OQ-- --C4lfdX7h60qaSrveoikmnnR700mWlehlb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJZRbLgAAoJEDXXcbtuRpfPAAsIAMPKtXWFrM3ujrBJ2xTHcvP9 IhbLiJHPwfSSQP65bXgCTPRYKhbqfcMq1Ppo41wlbAtpDMmDbP0+e9KIINUe2c6i Cv9XPk4kLtwfcsI+zaz/gJP2stOINshVw0E+GKDyIT225ycxd4hoaTuUfF9KJZKG Ei6AZkrmTgZ8kKZJ4jp1aDOO+5ZRCMc3CAW/LudM3k0Rddjp20DNViPIbHcf8apS aG4kCvp31IR6r5j+cRNCfXf+JuYByI85kDNItWl8zvsr7KDorM2D2FurQmEZwkIi egZkgXWq5psT6OoYdSQQF5Dw//ILp3UAN7ZwQ5qCOy9g8gOZesdRcIhBk5dRoVI= =Clqh -----END PGP SIGNATURE----- --C4lfdX7h60qaSrveoikmnnR700mWlehlb--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?26120b59-35f5-000f-0ddf-8cc51d6e56ac>