From owner-p4-projects@FreeBSD.ORG  Tue Aug 14 21:34:03 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id E5A8D16A469; Tue, 14 Aug 2007 21:34:02 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id BD96916A421
	for <perforce@freebsd.org>; Tue, 14 Aug 2007 21:34:02 +0000 (UTC)
	(envelope-from phk@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id B069513C45A
	for <perforce@freebsd.org>; Tue, 14 Aug 2007 21:34:02 +0000 (UTC)
	(envelope-from phk@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l7ELY25i002790
	for <perforce@freebsd.org>; Tue, 14 Aug 2007 21:34:02 GMT
	(envelope-from phk@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l7ELY2MK002787
	for perforce@freebsd.org; Tue, 14 Aug 2007 21:34:02 GMT
	(envelope-from phk@freebsd.org)
Date: Tue, 14 Aug 2007 21:34:02 GMT
Message-Id: <200708142134.l7ELY2MK002787@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	phk@freebsd.org using -f
From: Poul-Henning Kamp <phk@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 125155 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Aug 2007 21:34:03 -0000

http://perforce.freebsd.org/chv.cgi?CH=125155

Change 125155 by phk@phk_critter on 2007/08/14 21:33:36

	
	sysarch(I386_SET_GSBASE)'s argument is a pointer to the address, not
	the address itself.

Affected files ...

.. //depot/projects/valgrind/coregrind/m_syswrap/syswrap-x86-freebsd.c#4 edit

Differences ...

==== //depot/projects/valgrind/coregrind/m_syswrap/syswrap-x86-freebsd.c#4 (text+ko) ====

@@ -511,6 +511,7 @@
 PRE(sys_sysarch)
 {
    ThreadState *tst;
+   void **p;
 
    PRINT("sys_sysarch ( %d, %p )", ARG1, ARG2);
    PRE_REG_READ2(int, "sysarch",
@@ -522,9 +523,10 @@
 
       /* On FreeBSD, the syscall loads the %gs selector for us, so do it now. */
       tst = VG_(get_ThreadState)(tid);
+      p = ARG2;
       tst->arch.vex.guest_GS = (2 << 3) | 3;	/* GSEL(GUGS_SEL, SEL_UPL) */
       /* "do" the syscall ourselves; the kernel never sees it */
-      SET_STATUS_from_SysRes( sys_set_thread_area( tid, 2, (void *)ARG2 ) );
+      SET_STATUS_from_SysRes( sys_set_thread_area( tid, 2, *p ) );
 
       break;
    case VKI_I386_GET_GSBASE: