From owner-freebsd-firewire@FreeBSD.ORG  Wed Jun  9 02:31:02 2004
Return-Path: <owner-freebsd-firewire@FreeBSD.ORG>
Delivered-To: freebsd-firewire@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9160A16A4CE
	for <freebsd-firewire@freebsd.org>;
	Wed,  9 Jun 2004 02:31:02 +0000 (GMT)
Received: from tora.nunu.org (YahooBB219003182029.bbtec.net [219.3.182.29])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C668E43D53
	for <freebsd-firewire@freebsd.org>;
	Wed,  9 Jun 2004 02:31:01 +0000 (GMT)
	(envelope-from simokawa@sat.t.u-tokyo.ac.jp)
Received: from tora.nunu.org (unknown [192.168.1.2])
	by tora.nunu.org (Postfix) with ESMTP
	id 16B4D4DA1C; Wed,  9 Jun 2004 11:31:00 +0900 (JST)
Date: Wed, 09 Jun 2004 11:31:00 +0900
Message-ID: <87y8mxcviz.wl@tora.nunu.org>
From: Hidetoshi Shimokawa <simokawa@sat.t.u-tokyo.ac.jp>
To: Barry Bouwsma <freebsd-misuser@remove-NOSPAM-to-reply.NOSPAM.dyndns.dk>
In-Reply-To: <200406080857.i588vo301522@Mail.NOSPAM.DynDNS.dK>
References: <200406080857.i588vo301522@Mail.NOSPAM.DynDNS.dK>
User-Agent: Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.5 (Awara-Onsen)
	FLIM/1.14.5 (Demachiyanagi) APEL/10.6 MULE XEmacs/21.4 (patch 14) (Reasonable
	Discussion) (i386--freebsd)
MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen")
Content-Type: text/plain; charset=US-ASCII
cc: FreeBSD Firewire Developers <freebsd-firewire@freebsd.org>
Subject: Re: orb pointer printf() question
X-BeenThere: freebsd-firewire@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Firewire support in FreeBSD <freebsd-firewire.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-firewire>,
	<mailto:freebsd-firewire-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-firewire>
List-Post: <mailto:freebsd-firewire@freebsd.org>
List-Help: <mailto:freebsd-firewire-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-firewire>,
	<mailto:freebsd-firewire-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Jun 2004 02:31:02 -0000

At Tue, 8 Jun 2004 10:57:50 +0200 (CEST),
Barry Bouwsma wrote:
> 
> [drop the above ipv6-only address that only sometimes works from the
>  recipients and I'll catch up later from the archives, thanks]
> 
> 
> Moin, moin.
> 
> A quick question, concerning the following code:
> 
>         if ((sdev->flags & ORB_POINTER_ACTIVE) != 0) {
> SBP_DEBUG(0)
>                 printf("%s: orb pointer active\n", __func__);
> END_DEBUG
>                 sdev->flags |= ORB_POINTER_NEED;
>                 return;
>         }
> 
> This is in the sbp.c code from the time of 4.10, which is what I've
> used on my machine with a hard drive attached via firewire.
> 
> It seems to be working just fine, with the only thing being that
> the above printf() makes it to the kernel messages a few times
> each minute during disk activity.
> 
> Is this something for me to concern myself over?  What does it
> mean?
> 
> If it's harmless, would it be better to change the above SBP_DEBUG
> to be DEBUG(1) instead of (0) so as not to print at the default
> level of debugging, or is it better to log it as is?
> 
> 
> thanks
> barry bouwsma

It's harmless.

I believe that the default level of debugging is 0 and
the DEBUG(0) clauses is not executed.

/\ Hidetoshi Shimokawa
\/  simokawa@sat.t.u-tokyo.ac.jp
PGP public key: http://www.sat.t.u-tokyo.ac.jp/~simokawa/pgp.html