From owner-freebsd-current@FreeBSD.ORG  Tue Jun 20 20:07:29 2006
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 234C216A47C;
	Tue, 20 Jun 2006 20:07:29 +0000 (UTC)
	(envelope-from dmitry@atlantis.dp.ua)
Received: from postman.atlantis.dp.ua (postman.atlantis.dp.ua [193.108.47.1])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 650F043D48;
	Tue, 20 Jun 2006 20:07:27 +0000 (GMT)
	(envelope-from dmitry@atlantis.dp.ua)
Received: from smtp.atlantis.dp.ua (smtp.atlantis.dp.ua [193.108.46.231])
	by postman.atlantis.dp.ua (8.13.1/8.13.1) with ESMTP id k5KK7CGQ048202; 
	Tue, 20 Jun 2006 23:07:12 +0300 (EEST)
	(envelope-from dmitry@atlantis.dp.ua)
Date: Tue, 20 Jun 2006 23:07:12 +0300 (EEST)
From: Dmitry Pryanishnikov <dmitry@atlantis.dp.ua>
To: John Baldwin <jhb@freebsd.org>
In-Reply-To: <200606201002.07695.jhb@freebsd.org>
Message-ID: <20060620230149.S43840@atlantis.atlantis.dp.ua>
References: <449015DE.6090407@fer.hr> <ygemzcd9ji5.wl%ume@mahoroba.org>
	<20060616211540.D37640@atlantis.atlantis.dp.ua>
	<200606201002.07695.jhb@freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: Adi Pircalabu <apircalabu@bitdefender.com>, freebsd-current@freebsd.org,
	Hajimu UMEMOTO <ume@freebsd.org>, Ivan Voras <ivoras@fer.hr>,
	"current@freebsd.org" <current@freebsd.org>
Subject: Re: Linux-flashplugin7 & rtld - RFC
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Jun 2006 20:07:29 -0000


Hello!

On Tue, 20 Jun 2006, John Baldwin wrote:
>>> This patch is somewhat redundant.  Adding
>>>
>>> 	__weak_reference(dlsym, _dlsym);
>>>
>>> is enough.
>>
>>   Indeed, this also works for me. It would be nice to see this trivial
>> addition committed.
>
> I agree.  Do you have the __weak_reference() patch handy?

  Sure, here is the diff against HEAD:

--- libexec/rtld-elf/rtld.c.orig        Tue Mar 28 10:17:21 2006
+++ libexec/rtld-elf/rtld.c     Tue Jun 20 22:35:17 2006
@@ -137,6 +137,8 @@

  void r_debug_state(struct r_debug*, struct link_map*);

+__weak_reference(dlsym, _dlsym);
+
  /*
   * Data declarations.
   */

I'm not sure whether it's style(9)-compliant, it just works.

> John Baldwin

Sincerely, Dmitry
-- 
Atlantis ISP, System Administrator
e-mail:  dmitry@atlantis.dp.ua
nic-hdl: LYNX-RIPE