From owner-freebsd-ports@FreeBSD.ORG Fri Dec 17 01:20:10 2010 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BDC9E1065670; Fri, 17 Dec 2010 01:20:10 +0000 (UTC) (envelope-from jhelfman@experts-exchange.com) Received: from mail.experts-exchange.com (mail.experts-exchange.com [72.29.183.251]) by mx1.freebsd.org (Postfix) with ESMTP id 98A5A8FC0A; Fri, 17 Dec 2010 01:20:10 +0000 (UTC) Received: from mail.experts-exchange.com (localhost [127.0.0.1]) by mail.experts-exchange.com (Postfix) with ESMTP id 5A70B9C6005; Thu, 16 Dec 2010 17:20:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=e-e.com; h= user-agent:in-reply-to:content-disposition:content-type :content-type:mime-version:references:message-id:subject:subject :from:from:date:date:received:received:received; s=ee; t= 1292548810; x=1294363210; bh=OqpyvXxrzO3khgsfKolmjTUrWfiTlMxH+vx ZloF/p4U=; b=P4gyVvnI34SENjC8qYpjp17bw0Qs2QY8vjUhy7LzrVfItbef4vH LK6nULFLhEjrlangs7b1dbbWGogWzihvi9S++uk8BLXRTNbL/KuKEq9rjtJVWz5c 4nl/w2sPggr8I/2+8/lcNxsBqfySUVg0aTzobMJFBcZXxgrsqD8L1L30= X-Virus-Scanned: amavisd-new at experts-exchange.com Received: from mail.experts-exchange.com ([127.0.0.1]) by mail.experts-exchange.com (mail.experts-exchange.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YI7+rtt7Dnv0; Thu, 16 Dec 2010 17:20:10 -0800 (PST) Received: from experts-exchange.com (unknown [192.168.103.122]) by mail.experts-exchange.com (Postfix) with SMTP id E42559C6019; Thu, 16 Dec 2010 17:20:09 -0800 (PST) Received: (nullmailer pid 14196 invoked by uid 1001); Fri, 17 Dec 2010 01:17:07 -0000 Date: Thu, 16 Dec 2010 17:17:07 -0800 From: Jason Helfman To: Palle Girgensohn Message-ID: <20101217011706.GA89888@eggman.experts-exchange.com> References: <20101115174427.297c2d78@eggman> <89E39DA34D9EAD2AE23E0A20@girgBook.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <89E39DA34D9EAD2AE23E0A20@girgBook.local> X-Operating-System: FreeBSD 8.1-RELEASE X-Living-The-Dream: I love the SLO Life! User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Jason Helfman , pphillips@e-e.com, freebsd-ports@freebsd.org Subject: Re: postgresql patch X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Dec 2010 01:20:10 -0000 Hi Palle, Myself and Phil here at experts-exchange worked on a what we think to be a great patch that could in theory be considered for the other postgresql servers. The initial patch was not good, and I understand why that hasn't been considered. I put a follow-up patch, but found that did break as you pointed out. Today we put in a patch that fixes all of it, and makes the user, group and id configurable. Builds cleanly in Tinderbox, as well. http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/153136 We look forward to your comments on this. Thanks! Jason On Tue, Nov 16, 2010 at 08:38:02AM +0100, Palle Girgensohn thus spake: >I'll check it out, but I believe a correct patch is not quite as simple, it >needs some tuning when installing files as well, but I may be wrong. > >--On 15 november 2010 17.44.27 -0800 Jason Helfman > wrote: > >> Hi, >> >> I was hoping you would be able to consider implementing this PR >> (ports/113707) in all applicable versions if possible? >> >> This patch makes the postgresql_user a tunable variable. >> >> As it stands now, we are maintaining this internally due to this issue, >> and would rather release internal maintainership for such a small issue. >> >># diff files/postgresql.in.new files/postgresql.in.orig >> 36c36 >> < postgresql_user=${postgresql_user:-"pgsql"} >> --- >>> postgresql_user=pgsql >> >> This patch has been on "over to maintainer" since 2007, and was hoping >> you would have a moment to look at this. >> >> Thanks so much, >> Jason > > > > > -- Jason Helfman System Administrator experts-exchange.com http://www.experts-exchange.com/M_4830110.html